Checks for user key using json has instead of an explicit read and check#1642
Open
apatruni wants to merge 2 commits intoloklak:developmentfrom
Open
Checks for user key using json has instead of an explicit read and check#1642apatruni wants to merge 2 commits intoloklak:developmentfrom
apatruni wants to merge 2 commits intoloklak:developmentfrom
Conversation
sudheesh001
requested changes
Aug 22, 2020
Member
sudheesh001
left a comment
There was a problem hiding this comment.
This looks good. However I'd suggest a few changes before this can be merged.
Would it be possible to change the commit message to:
Checks for user key using json has instead of an explicit read and check
With the change in commit message, I think this can be approved.
Handing over the second review to @Orbiter
revmarcuspeter-cyber
approved these changes
Apr 6, 2026
revmarcuspeter-cyber
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
I have:
Fixes #<number> commit messageFor the reviewers
I have: