Skip to content

Checks for user key using json has instead of an explicit read and check#1642

Open
apatruni wants to merge 2 commits intoloklak:developmentfrom
apatruni:feature/codeimprovements
Open

Checks for user key using json has instead of an explicit read and check#1642
apatruni wants to merge 2 commits intoloklak:developmentfrom
apatruni:feature/codeimprovements

Conversation

@apatruni
Copy link
Copy Markdown

Short description

I have:

  • There is a corresponding issue for this pull request.
  • Mentioned the Issue number in the pull request commit message Fixes #<number> commit message
  • There is only strictly only one commit per issue.

For the reviewers

I have:

  • Reviewed this pull request by an authorized contributor.
  • The reviewer is assigned to the pull request.

Copy link
Copy Markdown
Member

@sudheesh001 sudheesh001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. However I'd suggest a few changes before this can be merged.

Would it be possible to change the commit message to:
Checks for user key using json has instead of an explicit read and check

With the change in commit message, I think this can be approved.

Handing over the second review to @Orbiter

@apatruni apatruni changed the title check for field Checks for user key using json has instead of an explicit read and check Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants