chore(deps): update autoscale docker tag to v5 - #179
Open
renovate[bot] wants to merge 1 commit into
Open
Conversation
Helm Template DiffNo rendered resource changes detected. |
Owner
Renovate Review:
|
| Check | Result |
|---|---|
| Inputs | Complete — PR body has a real ### Release Notes section with an explicit ##### BREAKING CHANGES block; one matching diff comment present (slug __no_diff__, used because this change lives in 02_bootstrap/** rather than a per-app 03_apps/apps/** path). |
| Description vs. diff | Consistent — table says autoscale 4.6.0→5.0.0; the only file changed is 02_bootstrap/03_traefik/Chart.yaml, bumping the autoscale dependency version only (single line, condition: autoscale.enabled unchanged). |
| Rendered diff | Full, no truncation — empty (_No rendered resource changes detected._). Confirmed why: 02_bootstrap/03_traefik/values.yaml sets autoscale.enabled: false, and neither values-prod.yaml nor values-test.yaml overrides it, so the dependency is condition-disabled in every environment and renders nothing. |
| Changelog vs. config | No overlap today — the stated breaking change (pods no longer auto-mount a ServiceAccount token unless serviceAccount.automountToken: true) can't manifest because the subchart isn't installed anywhere; repo-wide search found no automountToken key set at all. |
Details:
- Verified across all three value files for
02_bootstrap/03_traefik(values.yaml,values-prod.yaml,values-test.yaml): none setsautoscale.enabled: true, so this bump is currently inert at runtime. - The diff-bot's
__no_diff__slug (rather than a named-app slug) is expected here since the change is under02_bootstrap/, not03_apps/apps/.
Worth noting (non-blocking):
- If
autoscale.enabledis ever flipped totruelater, the new default (no auto-mounted ServiceAccount token) will apply immediately since nothing here currently setsserviceAccount.automountToken. Worth a quick check at that point, not now.
Why MEDIUM: Major version bump with a stated breaking change, but confirmed contained blast radius — the affected subchart is condition-disabled in every environment, so current runtime impact is zero. Flagged Medium (not Low) per the major-bump criterion, since Low is reserved for patch/minor bumps.
Generated by Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
4.6.0→5.0.0Release Notes
lunarys/generic-helm-chart (autoscale)
v5.0.0Compare Source
Features
BREAKING CHANGES
serviceAccount.automountToken is set to true. Workloads using an
in-cluster Kubernetes client, or sidecars injected by a mutating webhook
that needs the token, must opt in.
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.