chore(deps): update externalsecrets docker tag to v5 - #180
Open
renovate[bot] wants to merge 1 commit into
Open
Conversation
Helm Template Diff —
|
Owner
Renovate Review:
|
| Check | Result |
|---|---|
| Inputs | Partial — Release Notes present with an explicit BREAKING CHANGES block; one diff comment exists (03-apps-apps-cloudnative-pg), but it's blocked by a render error before any manifests are produced (see Rendered diff), so there's no template-output visibility for this app's secrets rendering. |
| Description vs. diff | Mismatch — see Details: scope silently exceeds the PR's single-package description. |
| Rendered diff | Not usable as evidence — see Details (pre-existing render error masks all output). |
| Changelog vs. config | No overlap in what's visible; can't be fully confirmed for this app due to the render error below. |
Details:
- Table names only
externalsecrets, and the PR does contain the expected pinned bump in03_apps/apps/cloudnative-pg/Chart.yaml(4.6.0→5.0.0) — but it also rewrites the fleet-wide defaultsecretsChartVersionin03_apps/values.yaml(4.6.0→5.0.0). That default is consumed by03_apps/charts/application-wrapper/templates/_application.tplfor every app that has asecrets.yamlfile without its ownversion:override. A repo-wide search found exactly four such apps:step-ca,crowdsec,longhorn, andauthentik— none pins its own version, so all four get silently bumped toexternalsecretsv5.0.0 by this PR, with no mention in the title/table, no file of theirs changed, and consequently zero diff-bot coverage. This is the fleet-wide-default scope gap called out in the review procedure's input-completeness check. - The
cloudnative-pgdiff comment shows the correct digest bump (ghcr.io/lunarys/charts/externalsecrets:4.6.0→5.0.0) but the overall Helm render then aborts:Error: postgresdb/templates/service-rw.yaml:8:35 executing "postgresdb/templates/service-rw.yaml" at <include "postgresdb.cnpg.clusterName" .>. This error line is unprefixed context — identical in both/tmp/old.yamland/tmp/new.yaml— so it's pre-existing on both renders and not introduced by this PR. It does mean, however, that the diff produces zero actual manifest output, so it cannot confirm or rule out any effect of the ServiceAccount-token breaking change on whatever this subchart creates forcloudnative-pg. cloudnative-pg/Chart-values.yaml'sexternalsecrets.secrets.*block only maps secret fields (s3-credentials,db-superuser); noserviceAccount/automountTokenkey. Repo-wide search found no app (including the 4 default-inheriting apps above) settingserviceAccount/automountTokenanywhere, so nothing currently opts in to the removed default token mount — but this can't be verified specifically forcloudnative-pg's own render given the error above.
Why MEDIUM: Major bump with a stated breaking change; the changed-file scope silently exceeds the PR's stated single-package description (reaches 4 more apps via a fleet-wide default with no review trail); and the one available diff comment can't serve as evidence due to a render error — three independent Medium triggers. Not High: the render error predates this PR (pre-existing context line, not introduced), and no live override was found to intersect the breaking change in what is visible.
Generated by Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
4.6.0→5.0.0Release Notes
lunarys/generic-helm-chart (externalsecrets)
v5.0.0Compare Source
Features
BREAKING CHANGES
serviceAccount.automountToken is set to true. Workloads using an
in-cluster Kubernetes client, or sidecars injected by a mutating webhook
that needs the token, must opt in.
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.