build: make dependency bumps release-driving - #14
Merged
Conversation
The dependency refresh in 5362e69 landed on main but produced no release: release-please reported "No user facing commits found ... skipping" because `build` is a hidden, non-bumping type in its defaults, so v0.1.1 is still the latest release while main carries newer substrate pins. For a library that is the wrong classification. A module bump changes what a consumer resolves through minimal version selection -- importing flatte now brings lipgloss v2.0.5 and the newer ultraviolet -- so it is user-facing and belongs in the changelog. Add explicit changelog-sections making `deps` and `build` user-facing while keeping docs/style/chore/refactor/test/ci hidden. Because release-please evaluates every commit since the last release, this retroactively picks up the already-merged refresh and should open a 0.1.2 release PR; nothing needs re-landing. Note that naming changelog-sections replaces the defaults wholesale, which is why every type is listed rather than just the changed ones. Dependabot previously labelled *both* module and GitHub Actions updates `build(deps)`, so making `build` releasable alone would have cut a release for CI-only changes that no consumer can observe. Give each ecosystem an explicit prefix instead: gomod uses `deps` (release-driving) and github-actions uses `ci` (hidden, no release). CONTRIBUTING.md documents both prefixes and why they differ.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dependency refresh in
5362e69landed on main but produced no release. The release-please run log is explicit:buildis a hidden, non-bumping type in release-please's defaults, sov0.1.1is still latest whilemaincarries newer substrate pins.Why that classification was wrong
For a library, a module bump changes what a consumer resolves through minimal version selection — importing
flattenow bringslipgloss v2.0.5and the newerultraviolet. That is user-facing and belongs in the changelog.Changes
release-please-config.json— explicitchangelog-sectionsmakingdepsandbuilduser-facing, keepingdocs/style/chore/refactor/test/cihidden. Namingchangelog-sectionsreplaces the defaults wholesale, which is why every type is listed rather than only the changed ones.Because release-please evaluates every commit since the last release, this retroactively picks up the already-merged refresh — expect a
0.1.2release PR once this lands. Nothing needs re-landing..github/dependabot.yml— Dependabot previously labelled both module and GitHub Actions updatesbuild(deps), so makingbuildreleasable alone would have cut a release for CI-only changes no consumer can observe. Each ecosystem now gets an explicit prefix:gomod→deps(release-driving),github-actions→ci(hidden).CONTRIBUTING.md— documents both prefixes and why they differ.Verification
Config files are data, not code, so CI can only prove they don't break the build; the real proof is the release PR that should appear after merge. Both files were syntax-checked locally, and the visible/hidden split was confirmed to be: visible
feat, feature, fix, perf, revert, deps, build.🤖 Generated with Claude Code