Skip to content

[WRONG BRANCH] fix(kiro): gate diagnostic request-body encoding behind debug flag - #236

Draft
luvs01 wants to merge 1 commit into
mainfrom
codex/propose-fix-for-kiro-request-body-allocation
Draft

[WRONG BRANCH] fix(kiro): gate diagnostic request-body encoding behind debug flag#236
luvs01 wants to merge 1 commit into
mainfrom
codex/propose-fix-for-kiro-request-body-allocation

Conversation

@luvs01

@luvs01 luvs01 commented Aug 10, 2026

Copy link
Copy Markdown
Owner

Motivation

  • The Kiro adapter was computing bodyBytes by calling new TextEncoder().encode(body).length while building requests, which forced a full UTF-8 encoding (and allocation) of the upstream request body even when diagnostic logging was disabled, creating a resource-exhaustion risk.

Description

  • Import isDebugEnabled and move the diagnostic bodyBytes computation and the debugProviderDiagnostic(...) call behind an if (isDebugEnabled()) gate in src/adapters/kiro.ts so expensive encoding only happens when provider debug is enabled.
  • Add a focused regression test to tests/kiro-stream.test.ts that spies on TextEncoder.prototype.encode and fails if it is called when diagnostics are disabled to prevent regressions.
  • Changes touch src/adapters/kiro.ts and tests/kiro-stream.test.ts and preserve existing runtime request shape and behavior when debug is enabled.

Testing

  • Ran the focused Kiro tests with bun test tests/kiro-stream.test.ts and the new regression (buildRequest does not encode the request body for diagnostics when debug is disabled) passed in the targeted runs.
  • Ran type checking with bun run typecheck which succeeded.
  • Ran privacy checks with bun run privacy:scan which succeeded.
  • Ran the full test suite (bun run test) which surfaced unrelated, environment-sensitive failures in management-auth tests (HTTP 403 responses) that are not caused by this change; the failures are outside the scope of this diagnostic-gating fix.

Codex Task

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@luvs01, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 1 minute

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 4a49247f-d0c3-4563-b2a4-8164b9e11bcc

📥 Commits

Reviewing files that changed from the base of the PR and between 121f1ad and e5dc7a8.

📒 Files selected for processing (2)
  • src/adapters/kiro.ts
  • tests/kiro-stream.test.ts

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Aug 10, 2026
@github-actions github-actions Bot changed the title fix(kiro): gate diagnostic request-body encoding behind debug flag [WRONG BRANCH] fix(kiro): gate diagnostic request-body encoding behind debug flag Aug 10, 2026
@github-actions

github-actions Bot commented Aug 10, 2026

Copy link
Copy Markdown

⏳ DRAFT

  • wrong target branch (main); retarget to dev.

What to do

  • Retarget this PR to dev — all contributions go to dev.

Its title has been prefixed with [WRONG BRANCH].
This pull request was already a draft. Its draft status will be preserved after every issue above is resolved.

@github-actions
github-actions Bot marked this pull request as draft August 10, 2026 02:11

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e5dc7a8c4d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tests/kiro-stream.test.ts
Comment on lines +1732 to +1734
test("buildRequest does not encode the request body for diagnostics when debug is disabled", async () => {
const encode = spyOn(TextEncoder.prototype, "encode").mockImplementation(() => {
throw new Error("diagnostic encoding must stay behind the debug gate");

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Explicitly disable all provider-debug sources in this test

When the test suite is launched with the supported OCX_DEBUG=1 environment setting, this test enters the diagnostic branch and the mocked encoder throws; this is reproducible with OCX_DEBUG=1 bun test tests/kiro-stream.test.ts --test-name-pattern 'buildRequest does not encode'. The shared setup only deletes legacy OCX_DEBUG_FRAMES, while isDebugEnabled() also reads OCX_DEBUG and runtime overrides, so explicitly clear/reset those sources (or force the runtime debug setting off) before asserting that diagnostics are disabled.

AGENTS.md reference: AGENTS.md:L228-L230

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant