Skip to content

[WRONG BRANCH] fix(providers): disable unverified Zhipu live model discovery - #244

Draft
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-zhipu-provider-live-discovery-issue
Draft

[WRONG BRANCH] fix(providers): disable unverified Zhipu live model discovery#244
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-zhipu-provider-live-discovery-issue

Conversation

@luvs01

@luvs01 luvs01 commented Aug 11, 2026

Copy link
Copy Markdown
Owner

Motivation

  • The Zhipu BigModel registry row shipped static model metadata but did not explicitly disable live /models discovery, which can cause the runtime to probe the unverified endpoint and replace the static catalog with an empty live response.

Description

  • Set liveModels: false on the zhipu-bigmodel entry in src/providers/registry.ts to keep the static catalog authoritative and avoid probing the unverified /api/paas/v4/models endpoint.
  • Tweak the nearby comment to reflect that live discovery is unverified and should remain disabled until verified.
  • Add a focused regression test in tests/provider-registry-parity.test.ts asserting the registry entry and its derived provider seed both have liveModels: false.

Testing

  • Ran bun run typecheck, which completed successfully.
  • Ran bun run privacy:scan, which passed.
  • Ran the focused test file with bun test tests/provider-registry-parity.test.ts, which failed to complete in this environment due to a Bun/runtime import error (Export named 'zstdDecompressSync' not found in module 'node:zlib') preventing the focused verification here.
  • Ran the broader bun run test suite locally in this environment; many tests passed but the run encountered unrelated timeouts in tests/grok-models-effort-list.test.ts, so a full-suite green was not achieved within this session.

Codex Task

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@luvs01, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 51 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: a8a259db-f473-41ac-afcf-2879e662b21d

📥 Commits

Reviewing files that changed from the base of the PR and between 6d881db and 53b0152.

📒 Files selected for processing (2)
  • src/providers/registry.ts
  • tests/provider-registry-parity.test.ts

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Aug 11, 2026
@github-actions github-actions Bot changed the title fix(providers): disable unverified Zhipu live model discovery [WRONG BRANCH] fix(providers): disable unverified Zhipu live model discovery Aug 11, 2026
@github-actions

github-actions Bot commented Aug 11, 2026

Copy link
Copy Markdown

⏳ DRAFT

  • wrong target branch (main); retarget to dev.

What to do

  • Retarget this PR to dev — all contributions go to dev.

Its title has been prefixed with [WRONG BRANCH].
This pull request was already a draft. Its draft status will be preserved after every issue above is resolved.

@github-actions
github-actions Bot marked this pull request as draft August 11, 2026 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant