Skip to content

[WRONG BRANCH] fix(ci): include .github/scripts and .github/workflows in CI allowlist #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
luvs01 wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −13
Draft

[WRONG BRANCH] fix(ci): include .github/scripts and .github/workflows in CI allowlist #246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,17 +32,15 @@ on:
- "scripts/**"
- "gui/**"
- "assets/**"
- ".github/scripts/**"
- ".github/workflows/**"
- ".gitattributes"
- ".npmignore"
- "package.json"
- "bun.lock"
- "tsconfig.json"
- "README.md"
- "LICENSE"
- ".github/workflows/ci.yml"
- ".github/workflows/release.yml"
- ".github/workflows/enforce-pr-target.yml"
- ".github/workflows/stale-needs-info.yml"
workflow_dispatch:

permissions:
Expand Down Expand Up @@ -180,17 +178,15 @@ jobs:
- 'scripts/**'
- 'gui/**'
- 'assets/**'
- '.github/scripts/**'
- '.github/workflows/**'
- '.gitattributes'
- '.npmignore'
- 'package.json'
- 'bun.lock'
- 'tsconfig.json'
- 'README.md'
- 'LICENSE'
- '.github/workflows/ci.yml'
- '.github/workflows/release.yml'
- '.github/workflows/enforce-pr-target.yml'
- '.github/workflows/stale-needs-info.yml'
gui:
- 'gui/**'
# Everything that ends up inside `npm pack`, or that decides what
Expand Down
9 changes: 4 additions & 5 deletions tests/ci-workflows.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,13 +301,12 @@ describe("GitHub Actions hardening", () => {

// The push trigger and pull-request `changes` job share one expensive-CI
// allowlist. PRs always create the workflow and aggregate check; this list
// decides whether the costly jobs run. Pin the entire list on both paths.
// decides whether the costly jobs run. Pin the entire list on both paths,
// including every script and workflow used by repository automation.
const ciPaths = [
".gitattributes",
".github/workflows/ci.yml",
".github/workflows/enforce-pr-target.yml",
".github/workflows/release.yml",
".github/workflows/stale-needs-info.yml",
".github/scripts/**",
".github/workflows/**",
".npmignore",
"LICENSE",
"README.md",
Expand Down
Loading