[WRONG BRANCH] fix(lab): redact bare hosts after socket errors - #249
[WRONG BRANCH] fix(lab): redact bare hosts after socket errors#249luvs01 wants to merge 1 commit into
Conversation
|
Warning Review limit reached
Next review available in: 31 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Comment |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Its title has been prefixed with |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c825f1ed54
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (token && isHostCandidate(token, resolver)) return m.replace(token, "[host]"); | ||
| if (!token) continue; | ||
| if (isHostCandidate(token)) return m.replace(token, "[host]"); | ||
| if (bareNamePossible && isHostCandidate(token, true)) return m.replace(token, "[host]"); |
There was a problem hiding this comment.
Avoid treating arbitrary errno prose as a hostname
When a socket error is followed by ordinary prose whose first word is absent from PROSE_AFTER_MARKER, isHostCandidate(token, true) accepts that word as a bare hostname. Consequently, common diagnostics such as ETIMEDOUT waiting for response become ETIMEDOUT [host] for response; worse, ETIMEDOUT connecting to gateway redacts connecting while leaving the actual host gateway exposed. Use positive destination syntax rather than a finite prose stoplist, and add regression cases for these phrasing variants.
Useful? React with 👍 / 👎.
Motivation
redis,gateway) and somehost:portforms unredacted after socket/error markers such asECONNREFUSEDandETIMEDOUT, leaking internal service names in Lab artifacts.Description
src/lab/artifacts/sanitize.tsto treat resolver and socket-state markers (includingECONNREFUSED,ETIMEDOUT,EHOSTUNREACH, anddial tcp|udp) as destination-bearing contexts while still preserving prose safeguards.host:portor… on port <n>first and redacting the host portion before other heuristics run.tests/lab-evidence-sanitization.test.tsthat assert redaction for socket-error forms (ECONNREFUSED redis,ETIMEDOUT gateway,dial tcp redis, etc.) while preserving natural-languageconnect tocases.Testing
bun run typecheckwhich succeeded locally in the environment used for the change.bun run privacy:scanwhich succeeded in this environment.sanitizeDiagnosticand validated the updated cases (8 targeted checks) which passed.bun test tests/lab-evidence-sanitization.test.tsand the fullbun run testwere blocked in this execution environment due to a Bun runtime mismatch (host has Bun 1.2.14 while the project expects Bun 1.3.14 andnode:zliblackszstdDecompressSync), so the full suite could not be completed here.Codex Task