[WRONG BRANCH] fix(images): intercept canonical image_gen for alias-only tool_choice - #250
[WRONG BRANCH] fix(images): intercept canonical image_gen for alias-only tool_choice#250luvs01 wants to merge 1 commit into
Conversation
|
Warning Review limit reached
Next review available in: 31 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Comment |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Its title has been prefixed with |
Motivation
plan.toolNamesby the originaltool_choice, which could remove the canonical synthetic nameimage_genwhen the client explicitly allowed only an alias (e.g.generate_image), causing rewrittenimage_gencalls to bypass the image bridge loop.Description
planImageBridgeinsrc/images/plan.tsto build the activation set from authorized hosted aliases while ensuring the canonicalIMAGE_GEN_TOOL_NAMEis present for interception once any image-generation name arms the bridge.tool_choice-based activation check while always advertising the synthetic interception name so downstream rewrites are fulfilled by the sidecar.tests/images/plan.test.tsto assert that an alias-onlytool_choiceplan contains both the alias and the canonicalimage_genentry.Testing
bun test tests/images/plan.test.tsusing the repository-pinned Bun (1.3.14) and all 18 tests passed.bun x tsc --noEmitand it succeeded.bun run testrun but stopped after unrelated, environment-dependent failures (Docker/timeout/race tests) and an initial Bun runtime mismatch (1.2.14) that caused an unrelatednode:zlibsymbol error; these failures are external to the change and the focused image-plan tests passed.Codex Task