Skip to content

[WRONG BRANCH] fix(images): intercept canonical image_gen for alias-only tool_choice - #250

Draft
luvs01 wants to merge 1 commit into
mainfrom
codex/propose-fix-for-image-alias-bridge-issue
Draft

[WRONG BRANCH] fix(images): intercept canonical image_gen for alias-only tool_choice#250
luvs01 wants to merge 1 commit into
mainfrom
codex/propose-fix-for-image-alias-bridge-issue

Conversation

@luvs01

@luvs01 luvs01 commented Aug 11, 2026

Copy link
Copy Markdown
Owner

Motivation

  • A recent change filtered plan.toolNames by the original tool_choice, which could remove the canonical synthetic name image_gen when the client explicitly allowed only an alias (e.g. generate_image), causing rewritten image_gen calls to bypass the image bridge loop.

Description

  • Update planImageBridge in src/images/plan.ts to build the activation set from authorized hosted aliases while ensuring the canonical IMAGE_GEN_TOOL_NAME is present for interception once any image-generation name arms the bridge.
  • Preserve the tool_choice-based activation check while always advertising the synthetic interception name so downstream rewrites are fulfilled by the sidecar.
  • Adjust tests/images/plan.test.ts to assert that an alias-only tool_choice plan contains both the alias and the canonical image_gen entry.

Testing

  • Ran the focused unit tests with bun test tests/images/plan.test.ts using the repository-pinned Bun (1.3.14) and all 18 tests passed.
  • Ran type checking with bun x tsc --noEmit and it succeeded.
  • Attempted a broader bun run test run but stopped after unrelated, environment-dependent failures (Docker/timeout/race tests) and an initial Bun runtime mismatch (1.2.14) that caused an unrelated node:zlib symbol error; these failures are external to the change and the focused image-plan tests passed.

Codex Task

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@luvs01, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 31 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 49a1c613-6daf-4e7e-bc89-f2992ec327ac

📥 Commits

Reviewing files that changed from the base of the PR and between 6d881db and c6a0eaf.

📒 Files selected for processing (2)
  • src/images/plan.ts
  • tests/images/plan.test.ts

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the bug Something isn't working label Aug 11, 2026
@github-actions

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@github-actions

github-actions Bot commented Aug 11, 2026

Copy link
Copy Markdown

⏳ DRAFT

  • wrong target branch (main); retarget to dev.

What to do

  • Retarget this PR to dev — all contributions go to dev.

Its title has been prefixed with [WRONG BRANCH].
This pull request was already a draft. Its draft status will be preserved after every issue above is resolved.

@github-actions github-actions Bot changed the title fix(images): intercept canonical image_gen for alias-only tool_choice [WRONG BRANCH] fix(images): intercept canonical image_gen for alias-only tool_choice Aug 11, 2026
@github-actions
github-actions Bot marked this pull request as draft August 11, 2026 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant