[WRONG BRANCH] fix(codex): preserve concurrent obsolete shim replacement - #258
[WRONG BRANCH] fix(codex): preserve concurrent obsolete shim replacement#258luvs01 wants to merge 1 commit into
Conversation
|
Warning Review limit reached
Next review available in: 24 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Comment |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Its title has been prefixed with |
Motivation
Description
rollbackObsoleteUnixShimRefresh()so rollback only unlinks a wrapper when the transaction recorded a fingerprint and the current file still matches it.setCodexShimObsoleteWriteHookForTests()to exercise the post-write replacement window.writeShim()so tests can simulate a concurrent replacement.obsolete Unix shim rollback preserves a concurrent current shimintests/codex-shim.test.tsthat verifies the rollback preserves a concurrent replacement, the backup, and the recorded state.Testing
bun test tests/codex-shim.test.ts --test-name-pattern 'obsolete Unix shim rollback preserves'and it passed.bun test tests/codex-shim.test.ts, which showed the new regression passing but exposed two pre-existing timing-sensitive failures unrelated to this change.bun run typecheckandbun run privacy:scan, both succeeded.bun run test; the run produced many passing tests but also encountered unrelated timeouts in other subsystems under the long test load (these failures are not caused by this patch).Codex Task