Skip to content

[WRONG BRANCH] fix(codex): preserve concurrent obsolete shim replacement - #258

Draft
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-obsolete-shim-rollback-issue
Draft

[WRONG BRANCH] fix(codex): preserve concurrent obsolete shim replacement#258
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-obsolete-shim-rollback-issue

Conversation

@luvs01

@luvs01 luvs01 commented Aug 13, 2026

Copy link
Copy Markdown
Owner

Motivation

  • Obsolete Unix shim rollback could delete a concurrently installed wrapper because it fell back to a public revision marker when a transaction had no recorded fingerprint.
  • The public marker is not proof of ownership and allowed a race where rollback removed another updater's shim, potentially breaking the user's codex launcher.

Description

  • Remove the marker-text fallback in rollbackObsoleteUnixShimRefresh() so rollback only unlinks a wrapper when the transaction recorded a fingerprint and the current file still matches it.
  • Add a test-only race hook setCodexShimObsoleteWriteHookForTests() to exercise the post-write replacement window.
  • Invoke the new hook immediately after the obsolete-path writeShim() so tests can simulate a concurrent replacement.
  • Add a regression test obsolete Unix shim rollback preserves a concurrent current shim in tests/codex-shim.test.ts that verifies the rollback preserves a concurrent replacement, the backup, and the recorded state.

Testing

  • Ran the focused regression: bun test tests/codex-shim.test.ts --test-name-pattern 'obsolete Unix shim rollback preserves' and it passed.
  • Ran the full shim test file: bun test tests/codex-shim.test.ts, which showed the new regression passing but exposed two pre-existing timing-sensitive failures unrelated to this change.
  • Ran static checks: bun run typecheck and bun run privacy:scan, both succeeded.
  • Attempted the full suite with bun run test; the run produced many passing tests but also encountered unrelated timeouts in other subsystems under the long test load (these failures are not caused by this patch).

Codex Task

@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@luvs01, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 24 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 94380470-0bc8-4d2a-bc72-06091811d06a

📥 Commits

Reviewing files that changed from the base of the PR and between 1193075 and 95d5032.

📒 Files selected for processing (2)
  • src/codex/shim.ts
  • tests/codex-shim.test.ts

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Aug 13, 2026
@github-actions github-actions Bot changed the title fix(codex): preserve concurrent obsolete shim replacement [WRONG BRANCH] fix(codex): preserve concurrent obsolete shim replacement Aug 13, 2026
@github-actions

github-actions Bot commented Aug 13, 2026

Copy link
Copy Markdown

⏳ DRAFT

  • wrong target branch (main); retarget to dev.

What to do

  • Retarget this PR to dev — all contributions go to dev.

Its title has been prefixed with [WRONG BRANCH].
This pull request was already a draft. Its draft status will be preserved after every issue above is resolved.

@github-actions
github-actions Bot marked this pull request as draft August 13, 2026 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant