[WRONG BRANCH] fix(packaging): skip symlinks during chmod traversal - #261
[WRONG BRANCH] fix(packaging): skip symlinks during chmod traversal#261luvs01 wants to merge 1 commit into
Conversation
|
Warning Review limit reached
Next review available in: 23 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Comment |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Its title has been prefixed with |
|
Superseded by a clean latest- |
Motivation
gui/distwith link-following APIs and couldchmodtargets outside the package when a symlink was present. This weakens local filesystem permissions during packaging.Description
lstatSyncinstead ofstatSyncand skip symbolic links so traversal does not follow or mutate symlink targets, preventing out-of-treechmodeffects inscripts/prepare-package.ts.chmodcalls behindif (import.meta.main) { ... }so tests can import the helper without triggering side effects.tests/install-scripts.test.tsthat creates a symlink fromgui/distto an external directory, runs the traversal helper, and asserts the external directory and file modes remain unchanged.Testing
bun test tests/install-scripts.test.tswhich passed (new symlink safety test included).bun run typecheck(bun x tsc --noEmit) which passed.bun run prepush(full suite); the run exercised many existing unrelated tests and encountered pre-existing failures/timeouts outside the scope of this change, so the focused checks above were used to validate the fix.Codex Task