Skip to content

[WRONG BRANCH] fix(packaging): skip symlinks during chmod traversal - #261

Closed
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-chmod-vulnerability-in-prepare-package
Closed

[WRONG BRANCH] fix(packaging): skip symlinks during chmod traversal#261
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-chmod-vulnerability-in-prepare-package

Conversation

@luvs01

@luvs01 luvs01 commented Aug 13, 2026

Copy link
Copy Markdown
Owner

Motivation

  • The package preparation script walked gui/dist with link-following APIs and could chmod targets outside the package when a symlink was present. This weakens local filesystem permissions during packaging.

Description

  • Use lstatSync instead of statSync and skip symbolic links so traversal does not follow or mutate symlink targets, preventing out-of-tree chmod effects in scripts/prepare-package.ts.
  • Make the traversal helper import-safe by gating the manifest generation and top-level chmod calls behind if (import.meta.main) { ... } so tests can import the helper without triggering side effects.
  • Add a focused regression test in tests/install-scripts.test.ts that creates a symlink from gui/dist to an external directory, runs the traversal helper, and asserts the external directory and file modes remain unchanged.

Testing

  • Ran bun test tests/install-scripts.test.ts which passed (new symlink safety test included).
  • Ran bun run typecheck (bun x tsc --noEmit) which passed.
  • Attempted bun run prepush (full suite); the run exercised many existing unrelated tests and encountered pre-existing failures/timeouts outside the scope of this change, so the focused checks above were used to validate the fix.

Codex Task

@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@luvs01, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 23 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: dfd0f042-e648-41c2-a1f1-8256e5934dbc

📥 Commits

Reviewing files that changed from the base of the PR and between 1193075 and bd5f0db.

📒 Files selected for processing (2)
  • scripts/prepare-package.ts
  • tests/install-scripts.test.ts

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the bug Something isn't working label Aug 13, 2026
@github-actions

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot changed the title fix(packaging): skip symlinks during chmod traversal [WRONG BRANCH] fix(packaging): skip symlinks during chmod traversal Aug 13, 2026
@github-actions

github-actions Bot commented Aug 13, 2026

Copy link
Copy Markdown

⏳ DRAFT

  • wrong target branch (main); retarget to dev.

What to do

  • Retarget this PR to dev — all contributions go to dev.

Its title has been prefixed with [WRONG BRANCH].
This pull request was already a draft. Its draft status will be preserved after every issue above is resolved.

@github-actions
github-actions Bot marked this pull request as draft August 13, 2026 00:44
@luvs01

luvs01 commented Aug 13, 2026

Copy link
Copy Markdown
Owner Author

Superseded by a clean latest-dev extraction with the permission-boundary fix expanded to both launcher files and the built output tree, plus Windows junction and POSIX link regressions. Closing this wrong-base draft shell; the branch remains available for history.

@luvs01 luvs01 closed this Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant