[WRONG BRANCH] fix(lab): restore automation scheduler intent on restart - #268
[WRONG BRANCH] fix(lab): restore automation scheduler intent on restart#268luvs01 wants to merge 1 commit into
Conversation
|
Warning Review limit reached
Next review available in: 52 seconds Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Comment |
|
✅ Deterministic PR hygiene checks passed. |
github-actions
Bot
changed the title
⏳ DRAFT
What to do
Its title has been prefixed with |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f4d04af5cb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| routeExecutor: productionLabRouteExecutor, | ||
| }); | ||
| if (loadLabAutomationPolicy(labConfigDir).enabled) { | ||
| if (loadLabAutomationConfig(labConfigDir).policy.enabled) { |
There was a problem hiding this comment.
When automation-config.json is malformed or its lock cannot be acquired, loadLabAutomationConfig throws here after Bun.serve has already bound the public listener and after the startup rollback block has ended. The caller receives no server handle to stop, leaving the listener and associated resources alive so a retry can fail with an address conflict; load the intent before binding or include this post-bind initialization in the existing rollback transaction.
Useful? React with 👍 / 👎.
| test("server startup reads scheduler intent from the committed automation config", () => { | ||
| const src = readFileSync(join(process.cwd(), "src/server/index.ts"), "utf8"); | ||
| expect(src).toContain("loadLabAutomationConfig(labConfigDir).policy.enabled"); | ||
| expect(src).not.toContain("loadLabAutomationPolicy(labConfigDir).enabled"); |
There was a problem hiding this comment.
This test only checks that a particular string appears in the source; it never writes an enabled combined config, starts the server, or verifies that the scheduler is running, so it would still pass if the loader or scheduler became a no-op and the restart regression returned. Add a behavioral test through a startup seam or live server that covers both an enabled committed config and a disabled committed config with stale legacy policy.
AGENTS.md reference: AGENTS.md:L231-L233
Useful? React with 👍 / 👎.
1 participant
Motivation
automation-policy.jsonvialoadLabAutomationPolicy()while the management API published the authoritative combined generation toautomation-config.json, so enabling automation through the API did not survive a restart and stale legacy files could spuriously start the scheduler.Description
loadLabAutomationConfigfromsrc/lab/automation/config-persistenceand switching the startup guard toloadLabAutomationConfig(labConfigDir).policy.enabled, and add a focused regression intests/lab-automation.test.tsthat asserts the startup source isloadLabAutomationConfig(...).policy.enabledand not the legacy loader.Testing
bun run typecheck, which succeeded, andgit diff --check, which reported no issues.node_modules/@oven/.../bin/bun test tests/lab-automation.test.ts), where the new regression passed but two pre-existing live-dispatch assertions in the same suite failed; runningbun testwith the system Bun (1.2.14) produced anode:zlibimport error unrelated to this change, and the fullbun run testrun was stopped after unrelated OAuth/API-key attribution failures.Codex Task