[WRONG BRANCH] fix(oauth): preserve legacy identity-less accounts on forced add-account login - #275
Closed
luvs01 wants to merge 1 commit into
Closed
[WRONG BRANCH] fix(oauth): preserve legacy identity-less accounts on forced add-account login#275luvs01 wants to merge 1 commit into
luvs01 wants to merge 1 commit into
Conversation
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Its title has been prefixed with |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
runLoginto passpreserveIdentityless: opts?.forceLogin === trueintosaveCredentialso forced add-account logins preserve an existing identity-less active slot for any provider instead of only forkiro(src/oauth/index.ts).tests/oauth-reauth-bind.test.ts).Testing
tests/oauth-reauth-bind.test.tsandtests/kimi-oauth-identity.test.ts, and both passed.bun run typecheckandbun run privacy:scan, and both succeeded.bun run test; many tests passed in this environment, but unrelated Grok model-discovery tests timed out and GUI dependency downloads returned HTTP 403, so the full-suite run is environment-limited rather than indicative of the change's correctness.Codex Task