Skip to content

Fixme - #12

Draft
hum-ph wants to merge 1 commit into
masterfrom
fixes
Draft

Fixme#12
hum-ph wants to merge 1 commit into
masterfrom
fixes

Conversation

@hum-ph

@hum-ph hum-ph commented Aug 8, 2026

Copy link
Copy Markdown
Collaborator

The fixes branch is intended to accumulate non-trivial bug fixes, refactoring,
and architectural improvements. We can describe and discuss it here.

@hum-ph

hum-ph commented Aug 8, 2026

Copy link
Copy Markdown
Collaborator Author

Bug №1: Segmentation fault in KnownMeteorites::Get.

New shared_ptr is created from a raw pointer (meteorite.get()), resulting in two independent
shared_ptr instances managing the same object. When the singleton is destroyed,
a double-free occurs.

Specifics of the singleton makes it possible to avoid using shared_ptr in favor of reference_wrapper.

Hotfixed in 69eec58.

@hum-ph hum-ph added the bug Something isn't working label Aug 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants