Healing a branch forces the refresh through enrichBranches - #105
Conversation
#103 taught branch:enrich to treat a ticket-less entry as a miss, but enrichBranches carries the same short-circuit one level down -- allCached is keyed on the branch merely being present in the store -- so the heal re-entered the enricher and got the same incomplete entry back without ever reaching the ticket lookup. Healing now passes forceRefresh. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe cache handler now forces enrichment when it heals incomplete cached branches. The regression test verifies the ChangesBranch cache healing
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The change forces branch healing to bypass the cache short-circuit and adds coverage for the requested behavior; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
Follow-up to #103, found by verifying it against the live daemon rather than trusting the unit test.
#103 made
branch:enrichtreat an entry with a resolved id and no ticket as a miss. ButenrichBrancheshas its own short-circuit —allCached = … branches.every(b => b.branch in store.entries)— keyed on mere presence, so the heal re-entered the enricher, hit that branch, and returned the sameticket: nullentry without ever reaching the Linear lookup. The heal was real and the effect was nil.Healing now passes
forceRefresh: true(the option enrichBranches already honors). The injected test seam receives the options so the behavior is pinned rather than assumed.Unit stage green (4,230).
🤖 Generated with Claude Code
Summary by CodeRabbit
Bug Fixes
Tests