fix(ci): take pkgver from the tag instead of release-please's extra-files - #13
Merged
Conversation
…iles
Listing PKGBUILD under release-please's `extra-files` made it fail to build a
release PR at all:
✔ Building candidate release pull request for path: .
❯ error message: Error: unexpected token '(' at 6:32, valid tokens [)]
✔ No user facing commits found since 8807472 - skipping
The feat that added the packaging job merged and produced no release PR, so the
package would never have been built — the same shape as the bug it was fixing,
one layer out.
The packaging job knows the tag, so it rewrites pkgver itself before makepkg and
greps to confirm the rewrite landed. That is stricter than the config coupling
was: the built package cannot carry a version the release does not. The value in
the file is now just the fallback for a manual makepkg from a checkout.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SYBhT1xfp3MQ1w3687F4Mp
This was referenced Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #12, from watching its own release-please run.
Listing
PKGBUILDunderextra-filesmade release-please fail to build a release PR at all:So #12 merged, no release PR appeared, and the packaging job it added would never have run. Same shape as the bug #12 was fixing — a release path that silently produces nothing — one layer out.
The packaging job already knows the tag, so it rewrites
pkgverbeforemakepkgand greps to confirm. Stricter than the config coupling: the package cannot carry a version its release does not.Suite: 159 passed, 2 skipped.
🤖 Generated with Claude Code
https://claude.ai/code/session_01SYBhT1xfp3MQ1w3687F4Mp