Conversation
- Add tempfile dependency for tests - Fix type annotations in storage and upload tests - Fix test_fractal_strategy_creation to properly initialize SurrealDB client - Fix test_complete_upload_flow to respect chunk size constraints - Resolve all clippy warnings: - Use .div_ceil() instead of manual division - Use is_none_or instead of map_or - Remove unnecessary format! calls - Fix field_reassign_with_default violations - Collapse nested if statements - Remove needless lifetimes - Use as_deref instead of as_ref().map() - Use .ends_with() instead of chars().last() - Apply cargo fmt to all files All 255 tests passing, clippy --lib clean, fmt check clean
test: fix all unit tests and clippy warnings
- Add #[expect(dead_code)] for utility functions and structs that are part of the API but not currently used in the binary - Add #[expect(clippy::enum_variant_names)] for ConfigError enum These are legitimate cases where code is kept for future extensibility.
- Change #[expect(dead_code)] to #[allow(dead_code)] - Change #[expect(clippy::enum_variant_names)] to #[allow(clippy::enum_variant_names)] expect() generates errors when the lint is not triggered in CI with -D warnings
# Conflicts: # Cargo.toml # src/api/error.rs # src/api/handlers.rs # src/api/progress.rs # src/db/connection.rs # src/main.rs # src/models/llm/brain.rs # src/models/llm/providers/ollama.rs # src/models/llm/strategy.rs # src/services/fractal_builder.rs # src/services/ingestion/service.rs # src/services/rem_phase.rs # src/services/storage/mod.rs # src/services/upload/mod.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.