ci: pin cygwin/cygwin-install-action to full commit SHA - #1261
ci: pin cygwin/cygwin-install-action to full commit SHA
#1261XananasX7 wants to merge 3 commits into
Conversation
|
And why do you pin just on the latest commit in their master instead of the version like they recommentd? That way we don't even get minor updates when fix stuff. |
0625e7f to
1ae00f5
Compare
|
Good call — I've updated the pin to the latest tagged release ( |
|
Better, but I would prefer v6, so we get 6.2 if it's released. I strongly doubt anyone will monitor all that stuff for updates. |
|
Updated — switched the pin from the |
Pins cygwin/cygwin-install-action to the commit SHA corresponding to the v6 major tag (8be4a72), rather than the v6.1 minor release. Using the major-tag SHA means the pin will cover future v6.x patch releases as they move the tag, matching the project maintainer's preference. Signed-off-by: El Mehdi Abenhazou <mehdiananas007@gmail.com>
c29c3be to
f5193a8
Compare
|
Good point @Vollstrecker — updated to pin against the Agreed on the monitoring concern — would you be open to a small |
|
I don't know renovate, usually I use dependabot. |
|
Updated to pin to |
…action SHA A previous commit accidentally truncated the Cygwin job block, leaving only a broken shell: line. Restore the full Cygwin job from upstream and pin cygwin/cygwin-install-action from the mutable @master reference to a fixed commit SHA: cygwin/cygwin-install-action@master -> 781ea34f8c7c28e794b807fb7120e93bfdac3089 SHA verified against the GitHub API.
|
Fixed the branch — a previous edit accidentally truncated the Cygwin job block down to a broken |
|
Friendly ping — happy to address any review comments. Thank you! |
|
The edits go back and forth reverting each other... There is essentially nothing to review as any previous review comments essentially got ignored due to constant reverting... Pinning to commit SHA is generally discouraged by project maintainers as it is maintainability burden as already pointed out. I agree with the previous comment about pinning to major release tag, so minor updates are followed, but major updates that might introduce incompatible changes need manual intervention. It's quite easy for humans to look at the version history to see how often new minor releases have been published for zlib and looking at the commit history it's obvious that there are quite long gaps between what is essentially bursts of commits. |
The msys-cygwin workflow uses
cygwin/cygwin-install-action@master— a mutable reference. Pinning to SHA hardens CI supply chain. Recommended by GitHub's security hardening guide and OpenSSF Scorecard.