contrib/minizip: neutralize directory Zip-Slip in miniunz - #1285
Open
M0nd0R wants to merge 3 commits into
Open
Conversation
CVE-2014-9485 mitigation (madler#908) only sanitized file member names. Directory-only entries still called mymkdir() on the raw archive path, so chained ../ directory members could create trees outside the extract root. Share a component-aware neutralize_extract_path() for both branches, preserve .hidden names, and use makedir() after neutralization.
CVE-2014-9485 mitigation (madler#908) only sanitized file member names. Directory-only entries still called mymkdir() on the raw archive path, so chained ../ directory members could create trees outside the extract root. Share a component-aware neutralize_extract_path() for both branches, preserve .hidden names, and use makedir() after neutralization.
CVE-2014-9485 mitigation (madler#908) only sanitized file member names. Directory-only entries still called mymkdir() on the raw archive path, so chained ../ directory members could create trees outside the extract root. Share a component-aware neutralize_extract_path() for both branches, preserve .hidden names, and use makedir() after neutralization.
|
@gvollant: Can you look it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mymkdir()on the raw member name.../directory entries can create directory trees outside the extraction root.neutralize_extract_path()used by both file and directory branches; preserve legitimate.hiddennames; usemakedir()after neutralization.Test plan
contrib/minizip/miniunzagainst currentdevelop../escape/,../escape/a/,../escape/a/b/no longer creates siblings outside extract dir; neutralized under extract root.config/directory entries still extract with leading dot preservedok/file.txtextract still worksRefs: #907 #908 CVE-2014-9485