Avoid crc32 narrowing warning - #1288
Open
bmehta001 wants to merge 1 commit into
Open
Conversation
The CRC is already masked to 32 bits, but Clang still diagnoses the implicit conversion from uLong to z_crc_t under -Wshorten-64-to-32. Make the intended narrowing explicit. Files changed: - crc32.c Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6b269873-a7bf-490e-a412-70a920868135
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1287.
crcis masked to 32 bits before the braided path, so this conversion is intentional. Make it explicit to avoid the Clang-Wshorten-64-to-32warning.Tested with a Clang build using
-Wshorten-64-to-32 -Werror, followed by the CMake tests on Linux and Windows.