Fix memory leak in minizip's zipOpen3 function - #1291
Open
amarkowski999 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
zipOpen3()is called withAPPEND_STATUS_ADDINZIPandLoadCentralDirectoryRecord()fails after partially reading the central directory, the error path leaks the datablock list and the file stream. Fixes #1223.Root Cause
The
zipOpen3()error path freedziinit.globalcommentandzi, but never calledfree_linkedlist(&ziinit.central_dir). The filestream was also only closed onLoadCentralDirectoryRecord()'s early-return path, not on its final error return, so it leaked on the later seek/read failures.Fix
LoadCentralDirectoryRecord(): close the filestream on its final error return, matching the existing early-error handling.zipOpen3(): callfree_linkedlist(&(ziinit.central_dir))on the error path.Verification
ASan before:
After: no leak, and the leaked file descriptor count returns to baseline.