ci: add permissions blocks to all workflows - #1295
Open
Alb3e3 wants to merge 86 commits into
Open
Conversation
So that ints.h is part of the installation.
The bug would pass off an invalid deflate stream as good, and copy uninitialized memory contents to the output.
Those were not quite enough if the workaround was enabled.
For pre-C99 Microsoft Visual Studio up through 2012.
This makes it easier to relocate the package since only one variable needs to be overridden.
The exec_prefix is meant for machine-specific files whereas headers are machine-independent.
The CMAKE_INSTALL_*DIR variables can be absolute. In that case they should not be appended to the prefix.
Co-authored-by: tbeu <tbeu@users.noreply.github.com>
Adding to NULL is undefined.
Add `permissions: contents: read` to all workflow files to follow the least-privilege principle. Without an explicit permissions block, workflows run with the default token permissions which include write access to repository contents and other resources. Files changed: - .github/workflows/c-std.yml - .github/workflows/cmake.yml - .github/workflows/configure.yml - .github/workflows/contribs.yml - .github/workflows/fuzz.yml - .github/workflows/msys-cygwin.yml - .github/workflows/others.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
permissions: contents: readto all workflow files.Why
Without an explicit
permissionsblock, GitHub Actions workflows run with the default token permissions, which include write access to repository contents, packages, and other resources.Adding
contents: readrestricts the token to read-only access, following the principle of least privilege. This reduces the potential impact if a dependency or action is compromised.Files (7)
Validation
git diff --checkpasses