inflate: total_in misses the header bytes on Z_NEED_DICT - #1297
Open
JasonGross wants to merge 1 commit into
Open
inflate: total_in misses the header bytes on Z_NEED_DICT#1297JasonGross wants to merge 1 commit into
JasonGross wants to merge 1 commit into
Conversation
case DICT: returns via RESTORE(); return Z_NEED_DICT; without reaching inf_leave, the only place total_in is updated. RESTORE() writes the advanced next_in/avail_in back, so the six header and DICTID bytes are never counted and total_in stays six short for the rest of the stream. Re-entering without setting a dictionary adds zero, so the count is not doubled. test/example.c: check total_in against the bytes actually consumed after the dictionary inflate. This fails without the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
case DICT:returns viaRESTORE(); return Z_NEED_DICT;without reachinginf_leave, so the six header + DICTID bytes it consumed are never added tototal_in. It stays six short throughZ_STREAM_END.No affected caller found.
The added check in
test/example.cfails without the fix.