Optimize ASCII nvarchar encoding in the direct writer - #198
Merged
Conversation
mag1cfrog
marked this pull request as ready for review
August 3, 2026 23:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nvarcharencode_utf16fallback for non-ASCII valuesWhy
The direct raw writer previously used the general UTF-8-to-UTF-16 iterator for every string during both measurement and encoding. ASCII values have a one-byte to one-code-unit mapping, so they can use a simpler byte path without changing the emitted TDS payload.
Performance
Three
wide_sparseruns with 1,000,000 rows, 16,384-row batches, and thedirect-rawbackend:A three-run
string_heavy_unicodeguard showed measurement and append/encode medians within 0.3% of the prior path, and Unicode sentinel validation passed.Validation
cargo fmt --checkcargo test --all-featurescargo clippy --all-targets --all-features -- -D warnings