v0.18.9 - Adds missing ParentChannelNum Property#97
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the library to v0.18.9 by adding support for a new parentChannelNum attribute across device and simulator models, and bumps a dependency requirement.
- Adds
parent_channel_numinDeviceChannel(init, JSON parsing, dict output) - Exposes
parentChannelNuminSimulatorChannel - Bumps
pycognitodependency and version number
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| simulator/models.py | Expose parentChannelNum on SimulatorChannel |
| pyproject.toml | Update pycognito requirement and other deps |
| pyemvue/device.py | Initialize, parse, and serialize parent_channel_num |
| pyemvue/version.py | Bump version to 0.18.9 |
Comments suppressed due to low confidence (1)
pyemvue/device.py:161
- Consider adding unit tests for parsing and serializing
parentChannelNuminDeviceChannel.from_json_dictionaryandas_dictionaryto ensure the new attribute behaves as expected.
if "parentChannelNum" in js:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces updates to versioning, dependency requirements, and enhancements to the
pyemvuelibrary's device channel handling. The changes include adding support for a new attribute,parentChannelNum, across multiple methods and classes, as well as updating dependencies and version numbers.Updates to
pyemvuelibrary:pyemvue/__version__.pyfrom0.18.8to0.18.9.parent_channel_num, to theDeviceChannelclass inpyemvue/device.py. This includes initializing it in the constructor (__init__), populating it from JSON infrom_json_dictionary, and including it in the dictionary representation inas_dictionary. [1] [2] [3]SimulatorChannelclass insimulator/models.pyto include theparentChannelNumattribute as an optional string.Dependency updates:
pycognitodependency version inpyproject.tomlfrom>=2024.2.0to>=2024.5.0.