Fix dynamic App Store auth endpoint discovery#493
Open
tosbaha wants to merge 1 commit into
Open
Conversation
|
What are the difference between this PR and this one? #490 |
Author
|
@ZomkaDEV I first tried their PR and it didn't work for me. I asked AI to fix it and my version worked. |
|
This one works well, thanks! |
|
Can vouch for this PR, worked for me as well, lifesaver, many thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems the App Store auth endpoint doesn't work. I tested end-to-end, and it worked for my old account, which doesn't have 2FA.
Disclaimer: Most of the code is written by AI, and I am putting it here so that maybe it can help you to solve this issue faster.
Summary by cubic
Fixes dynamic App Store auth endpoint discovery and normalization to keep login working when Apple changes URLs. We now default to the native
/fast/endpoint and retry login when a new endpoint is found in responses.authenticateAccountfrom the bag root orurlBag, normalize it, and fallback tohttps://auth.itunes.apple.com/auth/v1/native/fast/.ResponseDecodeErrorinpkg/httpto capture status, content type, a trimmed body, and extracted URLs for discovery.pkg/appstore(normalizeAuthEndpoint, etc.) and added tests covering bag, login retry, and normalization.Written for commit a98f833. Summary will update on new commits.