Add configurable y-offset for SketchyBar position - #7
Open
sameer-b wants to merge 1 commit into
Open
Conversation
- Add --y-offset CLI flag to Config.swift (CGFloat?, defaults to nil) - Update SketchyBarController to use configurable yOffset instead of hardcoded 0 - Preserve original behavior when --y-offset is not set - Add test for --y-offset parsing
Author
|
Addresses: #4 |
Author
|
@malpern 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes the
y_offsetused when showing SketchyBar configurable via a new--y-offsetflag. Previously the resting position was hardcoded toy_offset=0, which breaks for users who have a non-zeroy_offsetin their SketchyBar config. When the flag is not provided, behavior is identical to before (defaults to0).Changes
yOffsetproperty (CGFloat?, defaultnil) and--y-offset <px>argument parsingyOffsetininit. When set, uses the user value as the resting position andvalue - 50as the off-screen animation start. Whennil(default), uses original hardcoded valuesconfig.yOffsetto controller, includes it in startup log and help text--y-offsetparsing, updated default test to expectnilUsage
This lets users match whatever
y_offsetthey have configured in their SketchyBar config without sketchybar-toggle overriding it to0.Screen.Recording.2026-07-09.at.7.49.30.PM.mov