Retry authentication failures - #13
Open
dcollinsn wants to merge 2 commits into
Open
Conversation
added 2 commits
July 31, 2026 16:53
Acquire authorization before running privileged transactions and retry ordinary authentication failures. Abort promptly on Ctrl-C and detailed authorization errors, and retain authorization across long-running builds.
Use one timeout-based launch path for root and non-root transactions while preserving the existing delay for terminal Polkit agent registration.
Author
|
Before this patch, I tried I built I then repeated
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Have
pamac-cliexplicitly acquire authorization withTransaction.get_authorization_async()before starting a privileged transaction. Repeat a plain unsuccessful authorization request, but stop when authorization succeeds, the user presses Ctrl-C, or libpamac emits an error with diagnostic details.While authorization is pending, treat Ctrl-C as cancellation of the entire operation and return status 130. This ensures that losing the terminal agent cannot move the interaction to a GUI agent while the CLI transaction continues.
Resolves #12