Removed avx512_calls.c by replacing LUTs with intrinsics / shifts - #357
Open
manodeep wants to merge 4 commits into
Open
Removed avx512_calls.c by replacing LUTs with intrinsics / shifts#357manodeep wants to merge 4 commits into
avx512_calls.c by replacing LUTs with intrinsics / shifts#357manodeep wants to merge 4 commits into
Conversation
…d to calculate load-mask (taken from simSIMD)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AVX512 kernel was the only one that had a C source file for implementing lookup tables (LUTs) for floats and doubles. This has bothered me for a while, but now I finally know how to remove it (well, really the calculating partial load mask was the bottleneck and I got the solution from simSIMD, although simSIMD/numkong now appears to use
_bzhi- which requiresBMI2to be enabled at compile time and available at runtime - so theshiftmethod seemed safer)Ugghh My shell script / editor seems to have made some necessary but unasked for trailing-whitespace fixes as well :(