fix(macos): anchor popover to clicked display - #6
Open
60dage wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5
Summary
NSScreenand position theNSWindowagainst itsvisibleFrameWhy
Tauri's physical monitor coordinates can be inconsistent on vertically arranged mixed-DPI macOS displays. Combining those values with AppKit window coordinates can select the wrong screen or place the popover outside every visible frame.
The click's
NSEvent::mouseLocation()is already in the same coordinate space asNSScreenandNSWindow, so keeping the full placement path in AppKit coordinates avoids the scale conversion ambiguity.Related upstream reports:
TrayCenternot working on extended monitor when using multiple monitors [macOS] tauri-apps/plugins-workspace#724Testing
cargo check --manifest-path src-tauri/Cargo.tomlcargo test --manifest-path src-tauri/Cargo.toml— 95 passednpm test— 8 passednpm run buildThe reproduction setup is documented in #5; before/after screenshots will be attached there.