test: Wait for native view lifecycle completion - #1603
Draft
mrousavy wants to merge 1 commit into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Performance Report
iOS
All Benchmarks
AndroidPerformance is unchanged! 😎 All Benchmarks
Benchmarking Code Diff |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Harness rerender completion does not establish that Fabric has finished applying native props or recycling a removed view. The tests could therefore read old setter or lifecycle counts, particularly under sanitizer scheduling overhead.
Wait for changed hybridRef callbacks after prop updates and for the exact drop/recycle counts after removal. Publish lifecycle counts across the UI and JS threads using Android atomics and an iOS lock; publish recycle completion after resetting native state. This extracts only the view lifecycle changes from #1530 and uses Foundation's existing
NSLock.withLockinstead of custom locking helpers.Validation:
NSLock.withLocktype-checks against the iOS 15 simulator target.git diff --checkpasses. Fresh native builds and Harness tests run on this PR; earlier full Android validation is recorded in Stabilize Android Harness ASan and view lifecycle tests #1530.