Skip to content

chore(agent-feedback): file pruned babel helpers reachable from user config - #4063

Open
rturnq wants to merge 1 commit into
mainfrom
rturnquist-LK97DY4T2Y-payout-portal-310-w50uzf
Open

chore(agent-feedback): file pruned babel helpers reachable from user config#4063
rturnq wants to merge 1 commit into
mainfrom
rturnquist-LK97DY4T2Y-payout-portal-310-w50uzf

Conversation

@rturnq

@rturnq rturnq commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Files an agent-feedback item against packages/compiler/scripts/bundle.mts › pruneHelpers: the bundled Babel's helper table was trimmed to the four helpers the compiler's own transforms request, but getBaseBabelConfig enables .babelrc/configFile discovery for translated output, so user presets running inside the bundled Babel can request any of the other 118 helpers. A targetless @babel/preset-env fails with Unknown helper defineProperty, and affected apps cannot pin to an older compiler because the Marko 5 vdom translator needs the newer decodeHTML babel-utils export. The item records the failure, the no-pin-escape coupling, and a direction (restore the full table in the node bundle, ~112 KB); no fix is included.

🤖 Generated with Claude Code

https://claude.ai/code/session_01BeRtP7upctHWzWpWe8Esrp

@changeset-bot

changeset-bot Bot commented Aug 27, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 131778d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7e1e1618-d36a-45a1-902c-5cefe69f7d88

📥 Commits

Reviewing files that changed from the base of the PR and between b92887e and 131778d.

📒 Files selected for processing (1)
  • agent-feedback/items/2026-08-27-keep-user-reachable-babel-helpers-in-the-bundled.md

Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


Walkthrough

Adds a bug report for pruneHelpers removing user-reachable helpers from the Node Babel bundle. The report describes failures with targetless @babel/preset-env, including the Unknown helper defineProperty error. It proposes retaining the full helper table in dist/babel.js while preserving pruning in dist/babel.web.js. It also defines reproduction steps and helper-count checks.

Merge Risk: ⚪ Minimal · up to 13177

This PR only documents an existing Babel-helper compatibility issue and introduces no product or production behavior changes; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description clearly explains the bundled Babel helper-pruning issue, its cause, impact, and proposed direction. It matches the changeset.
Title check ✅ Passed The title clearly identifies the feedback item about user-reachable Babel helpers being pruned. It accurately summarizes the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch rturnquist-LK97DY4T2Y-payout-portal-310-w50uzf

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.76%. Comparing base (b92887e) to head (131778d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4063   +/-   ##
=======================================
  Coverage   90.76%   90.76%           
=======================================
  Files         424      424           
  Lines       20444    20444           
  Branches     3871     3871           
=======================================
  Hits        18557    18557           
  Misses       1325     1325           
  Partials      562      562           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant