Skip to content

agent-feedback: postfix-! parentheses and html-style body formatting - #146

Merged
DylanPiercey merged 1 commit into
mainfrom
dpiercey-ws-agent-scan-2pjwds
Aug 28, 2026
Merged

agent-feedback: postfix-! parentheses and html-style body formatting#146
DylanPiercey merged 1 commit into
mainfrom
dpiercey-ws-agent-scan-2pjwds

Conversation

@DylanPiercey

Copy link
Copy Markdown
Contributor

Files two items.

Formatting strips the parentheses around an attribute value ending in a TypeScript non-null !, which htmljs-parser then cannot parse, so --write breaks the template and a following --check reports the broken file as already formatted. The second records that <html-style> and <html-script> bodies are reformatted as embedded languages, which changes rendered bytes.

@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown

Warning

Review limit reached

  • Run on-demand review

On-demand reviews are free for the next 23 days. After that, they cost $0.25 per reviewed file.

Or wait 59 minutes for your next included review.

View limit details

Limit details: You’ve used all 5 included reviews currently available. Your 10 included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e0b466d1-d96a-4821-b6c8-b00c3d1566eb

📥 Commits

Reviewing files that changed from the base of the PR and between cdda63c and 0d051f3.

📒 Files selected for processing (2)
  • agent-feedback/items/2026-08-28-document-html-style-body-formatting.md
  • agent-feedback/items/2026-08-28-keep-parens-around-postfix-bang-attr-value.md

Comment @coderabbitai help to get the list of available commands.

@changeset-bot

changeset-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 0d051f3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov

codecov Bot commented Aug 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.83%. Comparing base (cdda63c) to head (0d051f3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #146   +/-   ##
=======================================
  Coverage   96.83%   96.83%           
=======================================
  Files           8        8           
  Lines         316      316           
  Branches       54       54           
=======================================
  Hits          306      306           
  Misses          4        4           
  Partials        6        6           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DylanPiercey
DylanPiercey merged commit 41defb7 into main Aug 28, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant