DP-39502: Build page analytics dashboard in powerbi v2#3333
Open
Eileleji wants to merge 18 commits into
Open
Conversation
added url to remove page title pane.
…n-powerbi-v2 * develop: DP-46580: Feedback manager help text (#3359) Added logger for detecting oversized headers and tracking their conte… (#3357) DP-46555-Pagination-on-Past-Events-Org-Page-returns-to-first-page-instead-of-advancing (#3355) changelog update and remove old changelog files DP-46553: Distinguish ClamAV scan-limit overruns from virus detections (#3351) Ensure Threads social media icons render for both threads.com and threads.net URLs on organization pages (#3356) Removed Percy/Browserstack (#3352) DP-45941: Allow Editors to Reference Blocked Users in “Authored By” Field for all report filters (#3316) DP-45856: Fix metadata related to robots noindex (#3302) changelog update and remove old changelog files DP-46568: Drupal security update 11.3.8 (#3348) Added fix from mayflower for close button keyboard trap (#3346)
…ashboard The Power BI iframe relies on third-party cookies for autoAuth, which modern browsers block by default. As a result the embedded report fails to render (or shows only a "Sign in" button that cannot be auto-clicked due to cross-origin restrictions). Replace the iframe with a launcher button that opens the report in a popup window where auth flows work normally.
Replaces the popup launcher with an inline short iframe (220px) so the Power BI sign-in button is visible above the fold. After signing in, an "Expand"/"Collapse" button toggles the iframe to its full report height, keeping the dashboard inline with the page.
The cross-origin iframe does not expose its DOM, so we cannot detect when the Power BI sign-in flow finishes. Instead we count load events on the iframe element: 4s without a new load implies the auth redirect chain has stabilised and the dashboard is showing, so we expand the iframe to full height. A 30s fallback handles cases where the chain never stabilises (blocked content, etc.). The manual Expand/Collapse button still works and disables the auto behaviour once the user takes over.
… heuristic" This reverts commit 77b4828.
The Expand/Collapse button and "Open in a new tab" link now appear both above and below the iframe so the controls are reachable from either side. Adds a "Keep expanded after reload" checkbox that persists the expanded state to localStorage and restores it on subsequent page loads. Both control rows stay in sync via shared CSS classes.
Changes the checkbox semantics from "always expand on reload" to "preserve
the user's last choice across reloads". When the checkbox is on, every
Expand/Collapse click is persisted; on page load, that state is restored.
When the checkbox is off, the iframe always starts collapsed at 220px.
Storage keys:
- mass_analytics_remember_state ("1" / "0")
- mass_analytics_iframe_state ("expanded" / "collapsed")
…tton Splits the controls into two rows: button and "Open in a new tab" link on the top row, "Remember state after reload" checkbox plus its description on the row below.
The expand/collapse state is now keyed by node ID so each analytics page remembers its own size independently. The "Remember state after reload" checkbox stays a single global preference; the per-node state is only read or written when that preference is on. Storage keys: - mass_analytics_remember_state (global toggle) - mass_analytics_iframe_state__<nid> (per-node)
The Remember-state checkbox is now also keyed by node ID, so each analytics page tracks both the preference and the saved state independently.
A null localStorage value (user never toggled the checkbox) is now treated as "on", and the rendered HTML reflects this so the checkbox shows as checked before the JS runs. Users keep the same behaviour by default; an explicit uncheck still persists as "0" and is honoured.
Drops the localStorage-backed Remember-state checkbox, its description, and the per-node storage keys. The Expand/Collapse toggle stays; the iframe always starts at the collapsed 220px height. Cleans up the unused node_id render variable and theme variable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Build page analytics dashboard in powerbi v2
Jira: (Skip unless you are MA staff)
DP-39502
To Test:
Peer Review Checklist