Skip to content

fix: preserve campaign timestamp ordering - #22

Open
VrtxOmega wants to merge 2 commits into
matheusht:mainfrom
VrtxOmega:fix/campaign-timestamp-order
Open

fix: preserve campaign timestamp ordering#22
VrtxOmega wants to merge 2 commits into
matheusht:mainfrom
VrtxOmega:fix/campaign-timestamp-order

Conversation

@VrtxOmega

Copy link
Copy Markdown

Summary

  • capture the campaign start timestamp when supervisor state is initialized
  • carry that timestamp through finalization so serialized campaign intervals cannot end before they start
  • add a regression assertion for chronological ordering

Reproduction

The documented sealed dry-run path produced this transcript interval on current main:

started_at: 2026-07-29T04:02:41.402147+00:00
ended_at:   2026-07-29T04:02:41.402125+00:00

ended_at was evaluated before Pydantic generated the default started_at, so the interval was inverted even though both fields were structurally valid.

After this change, a fresh run produced:

started_at: 2026-07-29T04:05:44.835058+00:00
ended_at:   2026-07-29T04:05:44.860988+00:00
order valid: true

Validation

  • pytest -q tests/test_supervisor.py tests/test_runtime_truth.py — 13 passed
  • uv sync --extra dev --extra research-gepa && make ci-pr — Ruff and mypy passed; 648 unit tests passed, 1 skipped; 25 offline golden tests passed
  • README sealed dry-run campaign completed successfully and the serialized transcript satisfied started_at <= ended_at

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9215913d30

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tests/test_supervisor.py Outdated
Split the 453-line supervisor test module into three focused modules so every module remains below the repository hard 200-line limit. Preserve all ten test ASTs and leave production behavior unchanged.

Verification: make ci-pr (Ruff, strict MyPy, 648 unit tests with 1 skip, and 25 sealed golden tests).

Assisted-by: OpenAI Codex
Human verification: VrtxOmega
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant