fix: preserve campaign timestamp ordering - #22
Open
VrtxOmega wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9215913d30
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Split the 453-line supervisor test module into three focused modules so every module remains below the repository hard 200-line limit. Preserve all ten test ASTs and leave production behavior unchanged. Verification: make ci-pr (Ruff, strict MyPy, 648 unit tests with 1 skip, and 25 sealed golden tests). Assisted-by: OpenAI Codex Human verification: VrtxOmega
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reproduction
The documented sealed dry-run path produced this transcript interval on current main:
ended_atwas evaluated before Pydantic generated the defaultstarted_at, so the interval was inverted even though both fields were structurally valid.After this change, a fresh run produced:
Validation
pytest -q tests/test_supervisor.py tests/test_runtime_truth.py— 13 passeduv sync --extra dev --extra research-gepa && make ci-pr— Ruff and mypy passed; 648 unit tests passed, 1 skipped; 25 offline golden tests passedstarted_at <= ended_at