Add reusable license check workflow for plugin repos - #46
Closed
snake14 wants to merge 5 commits into
Closed
Conversation
AltamashShaikh
left a comment
Contributor
There was a problem hiding this comment.
@snake14 Is this correct ?
Medium-risk issues
- Version drift between the reusable workflow ref and the checked-out script source. See .github/workflows/plugin-license-check.yml:11.
Contributor
Author
@AltamashShaikh Correct as an observation, but it's the same deliberate trade-off as plugin-phpstan.yml in #44: GitHub provides no context identifying a called reusable workflow's own commit ( |
10 tasks
AltamashShaikh
previously approved these changes
Aug 7, 2026
10 tasks
# Conflicts: # README.md
Contributor
Author
|
Closing as this will go into a new repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a reusable workflow (
.github/workflows/plugin-license-check.yml) plugin repositories can call to verify their licensing is consistent. It checks that the repository ships aLICENSE/LICENSE.mdfile matching the license declared inplugin.json, and that source files (*.php,*.js,*.ts,*.vue) carry the matching license header — the GPL header for OSS plugins, the InnoCraft EULA header for premium ones. A file carrying the opposite header fails the check; files with no recognized header are warnings (opt into failing via thefail-on-missing-headerinput). Repositories can skip files via glob patterns in a.license-check-ignorefile, e.g. bundled third-party code or released migrations.A caller workflow is a few lines (see the README section this PR adds). Piloted on innocraft/plugin-Funnels#289, where it runs green; local runs against LoginLdap and Funnels also caught real wrong-header files, since fixed (matomo-org/plugin-LoginLdap#459). The Funnels pilot pins its refs to this branch and switches to
@mainonce this merges.Checklist
Review