Skip to content

Remove the plugin-only PHPStan workflow and pre-push hook - #52

Merged
sgiehl merged 1 commit into
mainfrom
remove-plugin-quality-workflows
Aug 24, 2026
Merged

Remove the plugin-only PHPStan workflow and pre-push hook#52
sgiehl merged 1 commit into
mainfrom
remove-plugin-quality-workflows

Conversation

@snake14

@snake14 snake14 commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Description

Draft, opened to make the option concrete while we settle where plugin CI tooling should live — see the discussion on #49. Please do not merge before the replacement home exists.

Removes the two things in this repository that target plugins only, while this action serves both core and plugins:

Deliberately kept: the scripts/bash/checkout_dependent_plugins.sh hardening that also came in with #44. That script is called by action.yml itself, so it belongs here regardless of where the plugin workflows end up.

Nothing consumes the removed workflow yet — the only reference to plugin-phpstan.yml anywhere in matomo-org or innocraft was the README section this PR deletes — so removing it now costs a single move, whereas doing it after the per-plugin rollout would mean a PR in every plugin repository. That is the main reason to decide sooner rather than later.

The matomo5_min_php-style alias table is intentionally not part of this PR. #51 moves it out of action.yml into scripts/bash/resolve_php_version.sh, where it stays: it is shared by core and plugin CI alike, and a workflow in another repository can resolve it by checking this repository out at a pinned ref, which is how plugin-phpstan.yml already consumes the other shared scripts.

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

Both target plugins only, while this action serves core and plugins. They are
to be re-homed in a dedicated plugin CI repository.
@snake14
snake14 marked this pull request as ready for review August 20, 2026 21:46
@snake14
snake14 requested a review from sgiehl August 20, 2026 21:46
@snake14
snake14 marked this pull request as draft August 20, 2026 22:22
@sgiehl
sgiehl marked this pull request as ready for review August 24, 2026 07:23
@sgiehl
sgiehl merged commit 5685bac into main Aug 24, 2026
1 check passed
@snake14
snake14 deleted the remove-plugin-quality-workflows branch August 24, 2026 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants