Remove the plugin-only PHPStan workflow and pre-push hook - #52
Merged
Conversation
Both target plugins only, while this action serves core and plugins. They are to be re-homed in a dedicated plugin CI repository.
snake14
marked this pull request as ready for review
August 20, 2026 21:46
snake14
marked this pull request as draft
August 20, 2026 22:22
sgiehl
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Draft, opened to make the option concrete while we settle where plugin CI tooling should live — see the discussion on #49. Please do not merge before the replacement home exists.
Removes the two things in this repository that target plugins only, while this action serves both core and plugins:
.github/workflows/plugin-phpstan.yml(added in Add a reusable PHPStan workflow and the canonical pre-push hook, PG-4897 #44)hooks/pre-push, the canonical copy of the plugin PHPStan pre-push hook## Reusable workflowsand## Git hooksREADME sections that document themDeliberately kept: the
scripts/bash/checkout_dependent_plugins.shhardening that also came in with #44. That script is called byaction.ymlitself, so it belongs here regardless of where the plugin workflows end up.Nothing consumes the removed workflow yet — the only reference to
plugin-phpstan.ymlanywhere inmatomo-orgorinnocraftwas the README section this PR deletes — so removing it now costs a single move, whereas doing it after the per-plugin rollout would mean a PR in every plugin repository. That is the main reason to decide sooner rather than later.The
matomo5_min_php-style alias table is intentionally not part of this PR. #51 moves it out ofaction.ymlintoscripts/bash/resolve_php_version.sh, where it stays: it is shared by core and plugin CI alike, and a workflow in another repository can resolve it by checking this repository out at a pinned ref, which is howplugin-phpstan.ymlalready consumes the other shared scripts.Review