Skip to content

fix(windows): ship the right mavsdk_server for each architecture #825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julianoes merged 1 commit into from
Jul 22, 2026
+6 −4
Merged

fix(windows): ship the right mavsdk_server for each architecture #825

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ jobs:

- name: Create wheel
run: |
set MAVSDK_SERVER_ARCH=${{ matrix.arch }}
$env:MAVSDK_SERVER_ARCH = "${{ matrix.arch }}"
python3 setup.py bdist_wheel
Dir "dist/" | rename-item -NewName {$_.name -replace '-any.whl','-${{ matrix.wheel_arch }}.whl'}

Expand Down
8 changes: 5 additions & 3 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,12 +79,14 @@ def platform_suffix(self):
)

elif platform.system() == "Windows" and "MAVSDK_SERVER_ARCH" in os.environ:
# The released Windows assets are named with a .exe suffix, e.g.
# mavsdk_server_win_x86.exe -- without it the download 404s.
if os.environ["MAVSDK_SERVER_ARCH"] == "x86":
return "win_x86"
return "win_x86.exe"
elif os.environ["MAVSDK_SERVER_ARCH"] == "x64":
return "win_x64"
return "win_x64.exe"
elif os.environ["MAVSDK_SERVER_ARCH"] == "arm64":
return "win_arm64"
return "win_arm64.exe"
else:
raise NotImplementedError(
"Error: unknown MAVSDK_SERVER_ARCH: "
Expand Down