Fix docker container crashing when run with non-1000 user - #569
Open
na-ji wants to merge 1 commit into
Open
Conversation
UV_CACHE_DIR was hardcoded to /home/mediamanager/.cache/uv, owned by uid 1000. Running the container as any other non-root uid (e.g. via docker-compose `user:`) caused uv to fail with a permission error on startup, since it couldn't create the cache dir. Switched to /tmp/uv-cache, which is world-writable via the sticky bit regardless of uid/gid. Fixes maxdorninger#566
📝 WalkthroughWalkthroughThe Dockerfiles move the uv cache from the mediamanager home directory to ChangesContainer cache configuration
Estimated code review effort: 1 (Trivial) | ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UV_CACHE_DIRwas hardcoded to/home/mediamanager/.cache/uv, owned by uid 1000. Running the container as any other non-root uid (e.g.user: "1001:1001"in docker-compose) causeduvto crash on startup with a permission error, since it couldn't create the cache dir.UV_CACHE_DIRto/tmp/uv-cachein bothDockerfileandmetadata_relay/Dockerfile./tmpis world-writable via the sticky bit, so this works for any uid/gid without needing ownership changes.Fixes #566
Test plan
dependenciesstage from the pre-fix Dockerfile and reproduced the exact error from the issue running as uid 1001 and uid 99.dependenciesstage from the fixed Dockerfile and confirmeduv runworks as uid 1001, uid 99, uid 1000 (default), and root.Summary by CodeRabbit