Add 5-second rewind and forward controls for songs and podcasts#1584
Open
hemanth-thirdi wants to merge 1 commit into
Open
Add 5-second rewind and forward controls for songs and podcasts#1584hemanth-thirdi wants to merge 1 commit into
hemanth-thirdi wants to merge 1 commit into
Conversation
|
Its a great work well done, but I have something to add if you could implement it, to add an option to double press on left and right of the image to ±5/10 seconds |
Author
|
Sure, I'll try to implement this feature from my end. I really appreciate
your reply.
Thank you
…On Tue, Jun 23, 2026 at 3:04 PM karazoun ***@***.***> wrote:
*karazoun* left a comment (maxrave-dev/SimpMusic#1584)
<#1584 (comment)>
Its a great work well done, but I have something to add if you could
implement it, to add an option to double press on left and right of the
image to ±5 seconds
—
Reply to this email directly, view it on GitHub
<#1584?email_source=notifications&email_token=BUDO7NO6VFNRMJKDD4AEM7D5BJFL3A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINZXG44DANBSGA3KM4TFMFZW63VMON2GC5DFL5RWQYLOM5S2KZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-4777804206>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BUDO7NK6RO62V6Y3KW3X5BT5BJFL3AVCNFSNUABFKJSXA33TNF2G64TZHM3DEOBRGYYDIOBZHNEXG43VMU5TGNZXGY2TGMRRGE4KC5QC>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/BUDO7NJ2D7QPAAOBM4P3MGD5BJFL3A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINZXG44DANBSGA3KM4TFMFZW63VMON2GC5DFL5RWQYLOM5S2KZLWMVXHJKTGN5XXIZLSL5UW64Y>
and Android
<https://github.com/notifications/mobile/android/BUDO7NI3DSVQZAJFN3M3LH35BJFL3A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINZXG44DANBSGA3KM4TFMFZW63VMON2GC5DFL5RWQYLOM5S2KZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>.
Download it today!
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
Author
|
Do you want me to keep the forward and rewind buttons, or remove them?
I just wanted to confirm before implementing this feature
Thank you
Hemanth K R
…On Tue, Jun 23, 2026 at 6:38 PM Hemanth KR ***@***.***> wrote:
Sure, I'll try to implement this feature from my end. I really appreciate
your reply.
Thank you
On Tue, Jun 23, 2026 at 3:04 PM karazoun ***@***.***> wrote:
> *karazoun* left a comment (maxrave-dev/SimpMusic#1584)
> <#1584 (comment)>
>
> Its a great work well done, but I have something to add if you could
> implement it, to add an option to double press on left and right of the
> image to ±5 seconds
>
> —
> Reply to this email directly, view it on GitHub
> <#1584?email_source=notifications&email_token=BUDO7NO6VFNRMJKDD4AEM7D5BJFL3A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINZXG44DANBSGA3KM4TFMFZW63VMON2GC5DFL5RWQYLOM5S2KZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-4777804206>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/BUDO7NK6RO62V6Y3KW3X5BT5BJFL3AVCNFSNUABFKJSXA33TNF2G64TZHM3DEOBRGYYDIOBZHNEXG43VMU5TGNZXGY2TGMRRGE4KC5QC>
> .
> Triage notifications, keep track of coding agent tasks and review pull
> requests on the go with GitHub Mobile for iOS
> <https://github.com/notifications/mobile/ios/BUDO7NJ2D7QPAAOBM4P3MGD5BJFL3A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINZXG44DANBSGA3KM4TFMFZW63VMON2GC5DFL5RWQYLOM5S2KZLWMVXHJKTGN5XXIZLSL5UW64Y>
> and Android
> <https://github.com/notifications/mobile/android/BUDO7NI3DSVQZAJFN3M3LH35BJFL3A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINZXG44DANBSGA3KM4TFMFZW63VMON2GC5DFL5RWQYLOM5S2KZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>.
> Download it today!
> You are receiving this because you modified the open/close state.Message
> ID: ***@***.***>
>
|
|
idk, I saw Youtube music and Spotify they don't have these buttons, if you see they need to be there just keep them. |
Author
|
Thank you for the feedback. I actually modeled this feature after the
Spotify interface, which includes these controls for 15-second intervals. I
believe adding them makes the UI much more intuitive for the user.
Best regards,
Hemanth K R
…On Tue, 23 Jun, 2026, 7:06 pm karazoun, ***@***.***> wrote:
*karazoun* left a comment (maxrave-dev/SimpMusic#1584)
<#1584 (comment)>
idk, I saw Youtube music and Spotify they don't have these buttons, if you
see they need to be there just keep them.
—
Reply to this email directly, view it on GitHub
<#1584?email_source=notifications&email_token=BUDO7NM4SCYK77CLYF4MJZD5BKBXPA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINZXHE3TSMJQGUY2M4TFMFZW63VMON2GC5DFL5RWQYLOM5S2KZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-4779791051>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BUDO7NKAYH2V24NUGOEKE5L5BKBXPAVCNFSNUABFKJSXA33TNF2G64TZHM3DEOBRGYYDIOBZHNEXG43VMU5TGNZXGY2TGMRRGE4KC5QC>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/BUDO7NMRQAX7FF2JOKR576L5BKBXPA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINZXHE3TSMJQGUY2M4TFMFZW63VMON2GC5DFL5RWQYLOM5S2KZLWMVXHJKTGN5XXIZLSL5UW64Y>
and Android
<https://github.com/notifications/mobile/android/BUDO7NIHN2SICSN73NHCKU35BKBXPA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINZXHE3TSMJQGUY2M4TFMFZW63VMON2GC5DFL5RWQYLOM5S2KZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>.
Download it today!
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
Author
|
Hi,
I have implemented the feature you asked for.
Here is the Link to that PR
#2177
Hope this fits the description you are looking for
Thank you for taking the time to validate my changes.
Kind regards
Hemanth K R
…On Tue, Jun 23, 2026 at 7:44 PM Hemanth KR ***@***.***> wrote:
Thank you for the feedback. I actually modeled this feature after the
Spotify interface, which includes these controls for 15-second intervals. I
believe adding them makes the UI much more intuitive for the user.
Best regards,
Hemanth K R
On Tue, 23 Jun, 2026, 7:06 pm karazoun, ***@***.***> wrote:
> *karazoun* left a comment (maxrave-dev/SimpMusic#1584)
> <#1584 (comment)>
>
> idk, I saw Youtube music and Spotify they don't have these buttons, if
> you see they need to be there just keep them.
>
> —
> Reply to this email directly, view it on GitHub
> <#1584?email_source=notifications&email_token=BUDO7NM4SCYK77CLYF4MJZD5BKBXPA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINZXHE3TSMJQGUY2M4TFMFZW63VMON2GC5DFL5RWQYLOM5S2KZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-4779791051>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/BUDO7NKAYH2V24NUGOEKE5L5BKBXPAVCNFSNUABFKJSXA33TNF2G64TZHM3DEOBRGYYDIOBZHNEXG43VMU5TGNZXGY2TGMRRGE4KC5QC>
> .
> Triage notifications, keep track of coding agent tasks and review pull
> requests on the go with GitHub Mobile for iOS
> <https://github.com/notifications/mobile/ios/BUDO7NMRQAX7FF2JOKR576L5BKBXPA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINZXHE3TSMJQGUY2M4TFMFZW63VMON2GC5DFL5RWQYLOM5S2KZLWMVXHJKTGN5XXIZLSL5UW64Y>
> and Android
> <https://github.com/notifications/mobile/android/BUDO7NIHN2SICSN73NHCKU35BKBXPA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINZXHE3TSMJQGUY2M4TFMFZW63VMON2GC5DFL5RWQYLOM5S2KZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>.
> Download it today!
> You are receiving this because you modified the open/close state.Message
> ID: ***@***.***>
>
|
|
Great work thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added 5-second rewind and forward support to the media player.
Changes
Testing
Below is how the implementation looks
Note
This is my first open-source contribution—thanks a lot for taking the time to review it!
I am a big fan of this project. Thank you for all the work you’ve put into building and maintaining this project.
I’m also planning to extend this by adding a 10-second rewind/forward option.