feat(table-row-actions): inline per-row action buttons across core, Angular & React#4
Merged
Conversation
Core:
- New RowAction type ({ label, variant?, action }) and TableRow.actions[]
- Parse inline action buttons from a row's data-row-actions cell
- Any non-reserved data-* attr becomes a camelCased action param
(e.g. data-record-kind -> params.recordKind), merged with data-action-params
- Document the convention in the system prompt; add parser tests
Angular:
- Render the inline per-row action buttons
React renderer support is pending (see follow-up) — core emits
TableRow.actions; the React table renderer does not yet render them.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
- React renderer draws the inline per-row action buttons (variant-aware), emitting via onAction and stopping row-click propagation — matching Angular - Add row-action styles to the shipped React CSS - Demo: new 'Pending tasks' preset with a data-row-actions table Completes table-row-actions across core + Angular + React. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
mayeedwin
changed the title
- README: remove the Packages table; move Documentation to just before License - Demo guide (System prompt tab): add a copyable raw instruction block for non-TypeScript users, rendered from getSystemPromptInstruction() so it stays in sync with the library Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
- Phone breakpoint (<=600px): topbar wraps, tighter thread/composer padding - Guide modal fits small screens; tabs scroll horizontally when they overflow - Keep the version badge visible on mobile Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Give the actions column a fixed width in both header and body so the flex data columns line up; right-align the buttons. (React + Angular) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
- System prompt tab: replace the long raw-instruction preview with Copy + Download .txt actions (no need to render the whole block in the dialog) - Use 100dvh so mobile browser chrome doesn't clip the layout Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
- Page-level overflow-x guard; min-width:0 on chat/turn/inspector/input so wide blocks (tables, code, source) scroll internally instead of widening the page - Suggestion chips now scroll horizontally (nowrap) instead of wrapping to two rows Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…rder Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The code block's Copy button now emits an AgentActionEvent (type: copy-code, params.language) via onAction in addition to copying, so copy-code surfaces in the inspector like the other action types. (React + Angular) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Trim README to a demo-framed overview with the action-type table; shorten architecture/frameworks/prompts/theming/git_workflow (~53% fewer lines) while preserving block types, action types, API signatures and theme tokens. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds multiple labeled inline action buttons per table row, and lets domain
data-*attributes flow through as action params. Wired end-to-end: core + Angular + React + demo. Also folds in a small docs/demo polish (previously #5).Core (
@conversed/core)RowActiontype ({ label, variant?, action }) andTableRow.actions?: RowAction[]data-row-actionscell (excluded from the row's data cells)data-*attribute on an actionable element becomes a camelCased action param — e.g.data-record-kind→params.recordKind— merged with JSONdata-action-paramsRenderers
primary), emitting via the action output/onActionand stopping row-click propagationDemo
data-row-actionstable — buttons fire real Action Protocol events into the inspectorgetSystemPromptInstruction())Docs (folded in from #5)
Verification
TableRow.actionsand the extradata-*params at runtime