feat(theme+demo): custom button/dark-mode tokens, live row CTAs, table polish#8
Merged
Conversation
- Add themeable tokens: primaryContrast (auto-derived from primary luminance), buttonBg/buttonText/buttonBorderColor, codeBg/codeText - Replace hardcoded #fff on filled elements with --conversed-primary-contrast, and hardcoded blue hover tints with the derived --conversed-primary-alpha15 - Fix Angular chips/timeline white (#ffffff) fallbacks -> transparent (dark-mode) - Drop override-blocking 'box-shadow: none !important' Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
When a task-start/task-complete command fires (not navigation), update that
row in place: status flips to 'In progress' / 'Done ✓' and the buttons change
('Start' drops; 'Complete' becomes 'Completed'). Navigation actions are unaffected.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Theming — customizable buttons + dark-mode fixes
Addresses hard-to-override styles and white-on-white on dark backgrounds.
themeprop or--conversed-*CSS vars):primaryContrast,buttonBg,buttonText,buttonBorderColor,codeBg,codeText.primaryContrastauto-derives from the primary's luminance, so text on filled buttons/badges stays readable for any primary.--conversed-primary-alpha15(no more hardcoded blue), filled-element text uses--conversed-primary-contrast.#fffffffallbacks →transparent).box-shadow: none !important.--conversed-code-bg/-text).Neutrals (borders, muted text, code surface) remain overridable defaults from the
CONVERSED_GRAYramp — not tinted from primary (by design; atintNeutralsoption can be added later).Demo — live row-CTA feedback
A command row action (
task-start/task-complete, not navigation) now updates its row in place: status flips toIn progress/Done ✓,Startdrops,CompletebecomesCompleted.Table polish
Removed the outer
marginon.conversed-table-container(React + Angular).Verified: core/react/angular + demo build & lint clean.