fix(write): raise clear ValueError when variant/track sample intersection is empty#226
Merged
Merged
Conversation
…tion is empty (#225) Before this fix, an empty intersection produced an opaque array-geometry crash deep in _write_from_svar / Ragged.from_offsets. Now a guard after samples.sort() raises an actionable message before entering the write path. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #225.
Summary
gvl.writeaftersamples.sort()that raises a clearValueErrorwhen the variant/track sample intersection is empty, before entering_write_from_svartest_write_atomic.pyusing a VCF + BigWigs with intentionally disjoint sample IDsBefore / After
Before: opaque crash deep in
_write_from_svar/Ragged.from_offsets:After:
Test plan
pytest tests/unit/dataset/test_write_atomic.py::test_empty_sample_intersection_raises_clear_error— new regression test, passespytest tests/unit/dataset/test_write_atomic.py— all 8 tests pass🤖 Generated with Claude Code