[MCC-1476011] Python Lib-Create Get_dataset_versions() function - #18
Merged
Conversation
ibaig-mdsol
requested review from
afieraru-mdsol,
dsilaghi-mdsol and
slingampalli-mdsol
May 7, 2026 21:05
slingampalli-mdsol
requested changes
May 8, 2026
There was a problem hiding this comment.
Pull request overview
Adds support for listing dataset versions to the Python SDK by introducing a new DatasetVersion domain model and wiring a new get_dataset_versions() operation through the client/service/transport layers, plus unit tests.
Changes:
- Added
DatasetVersionmodel and exported it from the public package surface. - Implemented
get_dataset_versions()inDataConnectClient,DataConnectService, andDefaultDataConnectService, including Arrow Flight action mapping and resource mapping. - Added unit tests covering request construction, mapping, and error translation for dataset versions.
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_service.py | Adds service-level tests for get_dataset_versions() mapping, request body, and error handling. |
| tests/test_client.py | Adds client-level tests ensuring forwarding, context-manager close behavior, and connect wiring. |
| README.md | Fixes a typo/duplication and tweaks transport note formatting. |
| dataconnect/transport/arrow_flight/transport.py | Adds Arrow Flight action mapping for dataset_versions.list. |
| dataconnect/service/mappers.py | Adds resource_to_dataset_version() mapping function. |
| dataconnect/service/default.py | Implements DefaultDataConnectService.get_dataset_versions() with validation and error translation. |
| dataconnect/service/base.py | Extends the service interface to include get_dataset_versions(). |
| dataconnect/models.py | Introduces DatasetVersion dataclass. |
| dataconnect/client.py | Exposes get_dataset_versions() on the public client API. |
| dataconnect/init.py | Re-exports DatasetVersion as part of the public API. |
| .pre-commit-config.yaml | Changes the default Python interpreter used by pre-commit hooks. |
| .gitignore | Ignores Jupyter notebooks and checkpoint directories. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
slingampalli-mdsol
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feature
Python Lib-Create Get_dataset_versions() functionMCC-1476011Checklist
git commit --amend --no-editcommand to reduce commit messages when making small file changes (like changing linespacing).tests/folder.doc/folder.Changes Summary
get_dataset_versionsmethodUsage