Skip to content

[MCC-1475989] Create-get-studies - #19

Merged
ibaig-mdsol merged 10 commits into
mainfrom
MCC-1475989_Create-get-studies
May 8, 2026
Merged

[MCC-1475989] Create-get-studies#19
ibaig-mdsol merged 10 commits into
mainfrom
MCC-1475989_Create-get-studies

Conversation

@nmakarava-mdsol

@nmakarava-mdsol nmakarava-mdsol commented May 7, 2026

Copy link
Copy Markdown
Contributor

feature

Checklist

  • Review the pull request to fix typos and ensure variable/function names are intuitive, etc.
  • Make sure the pull request does not have excessive number of unnecessary commits. Utilize the git commit --amend --no-edit command to reduce commit messages when making small file changes (like changing linespacing).
  • Make sure you have added unit tests for the code changes. Tests should be added in the tests/ folder.
  • Modify docs, if required. Add any new documentation in the doc/ folder.
  • Rebase on latest active development branch (develop/main).

Changes Summary

Adds a get_studies(search_study_name=...) API across the client/service layers, including request-body construction for the studies.list action and accompanying unit tests.

Changes:

  • Extend DataConnectClient.get_studies and DataConnectService.get_studies to accept an optional search_study_name filter and delegate it through.
  • Implement request-body appending in DefaultDataConnectService.get_studies when search_study_name is provided.
  • Add service-layer input validation helper and tests covering empty body vs filtered body and invalid input types.

@gitguardian

gitguardian Bot commented May 7, 2026

Copy link
Copy Markdown

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
32568165 Triggered JSON Web Token b3452e5 dataconnect/test.ipynb View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Revoke and rotate the secret.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Comment thread dataconnect/service/default.py Outdated
@nmakarava-mdsol
nmakarava-mdsol marked this pull request as ready for review May 8, 2026 14:58
Copilot AI review requested due to automatic review settings May 8, 2026 14:58

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a get_studies(search_study_name=...) API across the client/service layers, including request-body construction for the studies.list action and accompanying unit tests.

Changes:

  • Extend DataConnectClient.get_studies and DataConnectService.get_studies to accept an optional search_study_name filter and delegate it through.
  • Implement request-body appending in DefaultDataConnectService.get_studies when search_study_name is provided.
  • Add service-layer input validation helper and tests covering empty body vs filtered body and invalid input types.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/test_service_default.py Adds unit tests for DefaultDataConnectService.get_studies, including request body behavior and input validation.
tests/test_client.py Adds delegation tests for DataConnectClient.get_studies and close().
dataconnect/service/validators.py Introduces validate_search_study_name helper for service-layer input validation.
dataconnect/service/default.py Adds search_study_name support to the default service implementation and appends JSON body when filtering.
dataconnect/service/base.py Updates the abstract service interface to include the optional filter parameter.
dataconnect/client.py Updates the public client API to accept and forward the optional filter parameter.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread dataconnect/service/validators.py
Comment thread dataconnect/service/validators.py
@ibaig-mdsol
ibaig-mdsol dismissed slingampalli-mdsol’s stale review May 8, 2026 18:18

Changes made. I'll merge

@ibaig-mdsol
ibaig-mdsol merged commit 18d874d into main May 8, 2026
3 checks passed
@ibaig-mdsol
ibaig-mdsol deleted the MCC-1475989_Create-get-studies branch May 8, 2026 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants