[MCC-1475989] Create-get-studies - #19
Conversation
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 32568165 | Triggered | JSON Web Token | b3452e5 | dataconnect/test.ipynb | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Revoke and rotate the secret.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
There was a problem hiding this comment.
Pull request overview
Adds a get_studies(search_study_name=...) API across the client/service layers, including request-body construction for the studies.list action and accompanying unit tests.
Changes:
- Extend
DataConnectClient.get_studiesandDataConnectService.get_studiesto accept an optionalsearch_study_namefilter and delegate it through. - Implement request-body appending in
DefaultDataConnectService.get_studieswhensearch_study_nameis provided. - Add service-layer input validation helper and tests covering empty body vs filtered body and invalid input types.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_service_default.py | Adds unit tests for DefaultDataConnectService.get_studies, including request body behavior and input validation. |
| tests/test_client.py | Adds delegation tests for DataConnectClient.get_studies and close(). |
| dataconnect/service/validators.py | Introduces validate_search_study_name helper for service-layer input validation. |
| dataconnect/service/default.py | Adds search_study_name support to the default service implementation and appends JSON body when filtering. |
| dataconnect/service/base.py | Updates the abstract service interface to include the optional filter parameter. |
| dataconnect/client.py | Updates the public client API to accept and forward the optional filter parameter. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
feature
Python Lib-Create Get Studies() functionMCC-1475989Checklist
git commit --amend --no-editcommand to reduce commit messages when making small file changes (like changing linespacing).tests/folder.doc/folder.Changes Summary
Adds a get_studies(search_study_name=...) API across the client/service layers, including request-body construction for the studies.list action and accompanying unit tests.
Changes: