[codex] Add base pose runtime API - #138
Draft
meekmachine wants to merge 1 commit into
Draft
Conversation
Owner
Author
PR backlog triage — REBASE_KEEPStill wanted on the Polymer / agencySociety / host plan. Next step: rebase onto current Base pose Embody API — rebase conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
capturePose,applyPose,setBasePose,resetToBasePose,resetToImportedRestPose, andsetBaseExpression.onReady(...), carry profile-backedcharacterPoses/basePoseId/basePosethrough preset/profile extension, and add coverage for base pose resets.Why
LoomLarge can now save/edit poses, but it needs Loom3 to own the actual reset/apply behavior. Base expressions are represented as FACS AU values and captured with their resolved constituent parts, so the base pose can restore both the semantic AU state and the concrete morph/bone state.
Validation
npm run typechecknpm test -- --run src/engines/three/Loom3.basePose.test.ts src/characters/extendCharacterConfigWithPreset.test.ts src/mappings/extendPresetWithProfile.test.tsnpm run buildPaired LoomLarge PR: meekmachine/LoomLarge#555
Related: meekmachine/LoomLarge#552