Conversation
mehadave
commented
Feb 2, 2026
mehadave
commented
Owner
- Added Login and SignUp pages
- Added LogOut button on Home page
- Checked backend and frontend connectivity
- Set up database
| jwt.init_app(app) | ||
|
|
||
| # Ensure models are imported before create_all | ||
| from . import models # noqa: F401 |
| with app.app_context(): | ||
| db.create_all() | ||
|
|
||
| # Register API routes (Blueprint) |
| @@ -1,5 +1,19 @@ | |||
| from werkzeug.security import generate_password_hash, check_password_hash | |||
Collaborator
There was a problem hiding this comment.
Please use passlib or bcrypt. https://medium.com/top-python-libraries/hashing-passwords-using-the-top-5-python-libraries-5ec530973b17
Comment on lines
+8
to
+11
| @api.get("/api/health") | ||
| def health(): | ||
| return jsonify({"status": "backend running"}) | ||
| return jsonify(status="backend running") | ||
|
|
|
|
||
| @api.post("/api/auth/signup") | ||
| def signup(): | ||
| data = request.get_json(silent=True) or {} |
Collaborator
There was a problem hiding this comment.
Why do we need silent=True? Can't we give 401 bad request?
|
|
||
| @api.post("/api/auth/login") | ||
| def login(): | ||
| data = request.get_json(silent=True) or {} |
Collaborator
There was a problem hiding this comment.
Why do we need to fail it silently? Send Bad Request to FE
| return jsonify(token=token), 200 | ||
|
|
||
|
|
||
| @api.get("/api/me") |
Collaborator
There was a problem hiding this comment.
What is this api doing?
Comment on lines
+56
to
+58
| def me(): | ||
| email = get_jwt_identity() | ||
| return jsonify(email=email), 200 |
| @@ -0,0 +1,135 @@ | |||
| import * as React from 'react'; | |||
Collaborator
There was a problem hiding this comment.
Don't need this import. Remove
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.