Skip to content

refactor(meshstack/noop): take the runner's endpoint from test_context #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JohannesRudolph merged 1 commit into from
Sep 7, 2026
+4 −8
Merged

refactor(meshstack/noop): take the runner's endpoint from test_context #314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/meshstack/noop/e2e/runner/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ module "backplane" {
source = "../../backplane"

meshstack_workspace_identifier = var.test_context.workspace
meshstack_endpoint = var.meshstack_endpoint
meshstack_endpoint = var.test_context.meshstack_endpoint
gcp_project_id = var.test_context.fixtures.gcp.project_id
gcp_region = var.gcp_region
gcp_resource_name_prefix = "noop-runner-${var.test_context.name_suffix}"
Expand Down
10 changes: 3 additions & 7 deletions modules/meshstack/noop/e2e/runner/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ variable "test_context" {
project = string
name_suffix = string

# Base URL of the meshStack API, written into the runner config for API polling.
meshstack_endpoint = string

# Project the runner's Cloud Run service and Secret Manager secrets live in.
fixtures = object({
gcp = object({
Expand All @@ -20,10 +23,3 @@ variable "gcp_region" {
default = "europe-west1"
description = "GCP region for the Cloud Run service and Secret Manager replicas."
}

# Not secret, so this belongs in test_context (see the e2e-test skill) — but the harness does not
# publish it there yet; it reaches CI through the secret pipe. Move it over once it does.
variable "meshstack_endpoint" {
type = string
description = "Base URL of the meshStack API. Written into the runner config for API polling."
}
Loading