fix(registry): guard against nil logger in RelationshipCSVHelper - #1086
fix(registry): guard against nil logger in RelationshipCSVHelper#1086Omkar-Ugal wants to merge 2 commits into
Conversation
Signed-off-by: Omkar Ugalmugle <omkarugalmugle285@gmail.com>
|
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, you can find updates in the #github-notifications channel in the community Slack. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughRelationship parsing now guards informational logging against a nil logger. Errors from the error channel are wrapped with ChangesRelationship parsing
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This is a localized fix for a nil logger panic in relationship parsing, with no actionable merge-blocking risk remaining beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Omkar Ugalmugle <omkarugalmugle285@gmail.com>
Description
This fixes a nil pointer panic in
RelationshipCSVHelper.ParseRelationshipsSheet()whenLogis not initialized.Signed commits
Summary by CodeRabbit
Bug Fixes