Sanitize ANSI escape sequences in CSP report logging - #1396
Closed
5H4D0WBY73 wants to merge 3 commits into
Closed
Conversation
Sanitize CSP report fields to prevent ANSI escape injection.
4 tasks
Collaborator
|
Thanks for the PR. Going to close this one in favor of #1397. Mainly just fixes some lint issues and a few other things. Thanks again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR sanitizes ANSI/VT100 escape sequences from untrusted CSP report fields before they are written to the terminal.
Root Cause
The
/__csp__endpoint logs attacker-controlled values directly usingprint(). ANSI escape sequences were preserved and interpreted by ANSI-compatible terminals.Fix
Closes the GHSA security advisory.